Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade exoplayer from 2.13.2 to 2.13.3 #2514

Closed
wants to merge 1 commit into from

Conversation

gauravpanta
Copy link

Full Error Log:

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':app:mergeDebugAssets'.

Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
Could not find com.google.android.exoplayer:exoplayer:2.13.2.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/google/android/exoplayer/exoplayer/2.13.2/exoplayer-2.13.2.pom
- file:/home/devilslayer/.m2/repository/com/google/android/exoplayer/exoplayer/2.13.2/exoplayer-2.13.2.pom
- file:/mnt/1EACD2FB2E5964FF/Development/Sandbox/vaderInterloper/node_modules/react-native/android/com/google/android/exoplayer/exoplayer/2.13.2/exoplayer-2.13.2.pom
- file:/mnt/1EACD2FB2E5964FF/Development/Sandbox/vaderInterloper/node_modules/jsc-android/dist/com/google/android/exoplayer/exoplayer/2.13.2/exoplayer-2.13.2.pom
- https://dl.google.com/dl/android/maven2/com/google/android/exoplayer/exoplayer/2.13.2/exoplayer-2.13.2.pom
- https://www.jitpack.io/com/google/android/exoplayer/exoplayer/2.13.2/exoplayer-2.13.2.pom
Required by:
project :app > project :react-native-video
Could not find com.google.android.exoplayer:extension-okhttp:2.13.2.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/google/android/exoplayer/extension-okhttp/2.13.2/extension-okhttp-2.13.2.pom
- file:/home/devilslayer/.m2/repository/com/google/android/exoplayer/extension-okhttp/2.13.2/extension-okhttp-2.13.2.pom
- file:/mnt/1EACD2FB2E5964FF/Development/Sandbox/vaderInterloper/node_modules/react-native/android/com/google/android/exoplayer/extension-okhttp/2.13.2/extension-okhttp-2.13.2.pom
- file:/mnt/1EACD2FB2E5964FF/Development/Sandbox/vaderInterloper/node_modules/jsc-android/dist/com/google/android/exoplayer/extension-okhttp/2.13.2/extension-okhttp-2.13.2.pom
- https://dl.google.com/dl/android/maven2/com/google/android/exoplayer/extension-okhttp/2.13.2/extension-okhttp-2.13.2.pom
- https://www.jitpack.io/com/google/android/exoplayer/extension-okhttp/2.13.2/extension-okhttp-2.13.2.pom
Required by:
project :app > project :react-native-video

     This PR is a fix for the above issue.

@KingAmo
Copy link

KingAmo commented Oct 19, 2021

you save my day! thanks!

@ebaynaud
Copy link

ebaynaud commented Oct 21, 2021

react-native-video+5.2.0.patch with https://github.com/ds300/patch-package

diff --git a/node_modules/react-native-video/android-exoplayer/build.gradle b/node_modules/react-native-video/android-exoplayer/build.gradle
index d005a58..6a9922b 100644
--- a/node_modules/react-native-video/android-exoplayer/build.gradle
+++ b/node_modules/react-native-video/android-exoplayer/build.gradle
@@ -28,7 +28,7 @@ android {
 
 dependencies {
     implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
-    implementation('com.google.android.exoplayer:exoplayer:2.13.2') {
+    implementation('com.google.android.exoplayer:exoplayer:2.13.3') {
         exclude group: 'com.android.support'
     }
 
@@ -37,7 +37,7 @@ dependencies {
     implementation "androidx.core:core:1.1.0"
     implementation "androidx.media:media:1.1.0"
 
-    implementation('com.google.android.exoplayer:extension-okhttp:2.13.2') {
+    implementation('com.google.android.exoplayer:extension-okhttp:2.13.3') {
         exclude group: 'com.squareup.okhttp3', module: 'okhttp'
     }
     implementation 'com.squareup.okhttp3:okhttp:${OKHTTP_VERSION}'

@NotGeorgeMessier
Copy link

NotGeorgeMessier commented Nov 16, 2021

Full Error Log:

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup. Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':app:mergeDebugAssets'.

Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
Could not find com.google.android.exoplayer:exoplayer:2.13.2.
Searched in the following locations:

     This PR is a fix for the above issue.

Do you know why does it works well only for 2.13.2 up to 2.13.3?
but it doesnt for version 2.15/16
May this lib needed be updated in larger scale, for correct migration to 2.15/16?

Is there some risk that 2.13.3 became deprecated as 2.13.2 soon?

@brunopuzoni
Copy link

any hope to have this released?

@jarod-legault
Copy link

Can I suggest renaming this PR to "Upgrade exoplayer from 2.13.2 to 2.13.3" since that is all it is doing?

According to this comment:

It looks like artifacts are being published to Google's Maven Repository starting with version 2.13.3 for now! 🎉
https://maven.google.com/web/index.html?q=exoplayer

This is required in order to remove the jcenter() repository from projects and use maven() instead.

Hopefully this can be merged and released soon.

@gauravpanta gauravpanta changed the title Fix for exoplayer 2.13.2 not found issue in android Upgrade exoplayer from 2.13.2 to 2.13.3 Jan 13, 2022
@gauravpanta
Copy link
Author

Can I suggest renaming this PR to "Upgrade exoplayer from 2.13.2 to 2.13.3" since that is all it is doing?

According to this comment:

It looks like artifacts are being published to Google's Maven Repository starting with version 2.13.3 for now! 🎉
https://maven.google.com/web/index.html?q=exoplayer

This is required in order to remove the jcenter() repository from projects and use maven() instead.

Hopefully this can be merged and released soon.

Done!

@andrewhavens
Copy link

jcenter is down again today. Can we get a merge and new version release?

@D-sandaruwan
Copy link

Can you merge this PR quickly? Because, we are gonna use this library for a large-scale commercial application. Therefore, this can be a major blocker when it comes to development.

@hueniverse hueniverse closed this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants