refactor: internal refactor for prepare new arch #3980
Conversation
- parse shutterColor value within JS - remove internal fullscreen state
|
need to change target brach ! |
|
@freeboub |
There was a problem hiding this comment.
@freeboub I agree with @YangJonghun this PR mainly refactor names and types - it does not introduce any logic/behaviour change for user, so we can merge this into master. Also it will be easier to sync this later
- rename and add wrapper
YangJonghun
force-pushed
the
refactor/prepare-new-arch
branch
from
8ef9180 to
58d43d8
Compare
|
Ok for me, let's go ! |
|
@freeboub @KrzysztofMoch So, I add below commit within this PR. related issue : #3998 |
|
Yeah I saw it - Thanks! I merged this and I will do |
* chore(js): fix typo * refactor(js): refactor type code for codegen * refactor(js): refactor Video component - parse shutterColor value within JS - remove internal fullscreen state * chore(js): add deprecation warning comment * fix(js): fix return type * fix(js): fix import path * refactor(android): apply changed API for new arch * refactor(ios): apply changed API for new arch * fix(ios): fix wrong name * refactor: refactor VideoDecoderProperties - rename and add wrapper * refactor(android): Code fixes for backward compatibility with Kotlin
* chore(js): fix typo * refactor(js): refactor type code for codegen * refactor(js): refactor Video component - parse shutterColor value within JS - remove internal fullscreen state * chore(js): add deprecation warning comment * fix(js): fix return type * fix(js): fix import path * refactor(android): apply changed API for new arch * refactor(ios): apply changed API for new arch * fix(ios): fix wrong name * refactor: refactor VideoDecoderProperties - rename and add wrapper * refactor(android): Code fixes for backward compatibility with Kotlin
Summary
refactor: internal refactor for prepare new arch
Motivation
Changes
Test plan