feat(iOS): add handler for Apple Earpods play/pause command #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharnik
changed the title
| guard let self, let player = self.currentPlayer else { | ||
| return .commandFailed | ||
| } | ||
|
|
There was a problem hiding this comment.
//Additional check: Is the player ready to play?
guard player.currentItem?.status == .readyToPlay else {
return .commandFailed
}
@KrzysztofMoch
WDYT?
There was a problem hiding this comment.
This is same code than play and pause handling. Looks good to me
freeboub
approved these changes
Aug 26, 2024
seyedmostafahasani
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new InfoCenterManager command that handles custom behaviour of Apple's wired earphones.
Motivation
Our customers reported that using Apple Earpods they can only adjust the volume, but not play/pause the video.
Apple Earpods also allow to skip to next/previous track, but as this concept (playlists) is more complicated I've decided not to add any behaviour for that commands.
Changes
togglePlayPauseCommandsent by Apple Earpods that resumes or pauses the video based on its state.Test plan
Play a video with Apple Earpods plugged in and use the play/pause button to stop and resume playback.
If you don't have access to this hardware, I can provide a video of the behaviour before and after the change.