Fix NullPointerException in setEnterPictureInPictureOnLeave for unsupported Android versions

[bae-unidev]

Summary

A NullPointerException was occurring when calling setEnterPictureInPictureOnLeave on devices running Android versions below Build.VERSION_CODES.O. The issue was caused by the fact that PictureInPictureUtil#applyAutoEnterEnabled was being called even for unsupported Android versions, where pictureInPictureParamsBuilder might not be initialized, leading to a null parameter passed to the Kotlin function applyAutoEnterEnabled.

public ReactExoplayerView(ThemedReactContext context, ReactExoplayerConfig config) {
  // ...
  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && pictureInPictureParamsBuilder == null) {
       this.pictureInPictureParamsBuilder = new PictureInPictureParams.Builder();
  }
  // ...

Fatal Exception: com.facebook.react.bridge.JSApplicationIllegalArgumentException
Error while updating property 'enterPictureInPictureOnLeave' of a view managed by: RCTVideo
          Caused by java.lang.NullPointerException: Parameter specified as non-null is null: method com.brentvatne.exoplayer.PictureInPictureUtil.applyAutoEnterEnabled, parameter pipParamsBuilder
       at com.brentvatne.exoplayer.PictureInPictureUtil.applyAutoEnterEnabled(PictureInPictureUtil.kt)
       at com.brentvatne.exoplayer.ReactExoplayerView.setEnterPictureInPictureOnLeave(ReactExoplayerView.java:2156)
       at com.brentvatne.exoplayer.ReactExoplayerViewManager.setEnterPictureInPictureOnLeave(ReactExoplayerViewManager.kt:169)

[YangJonghun]

@bae-unidev
Thanks for contribute:)
It was my mistake within #3385

How about modifying applyAutoEntryEnabled like below? I wanted to reduce complexity of the ReactExoplayerView by branching from PictureInPictureUtil if possible.

-    fun applyAutoEnterEnabled(context: ThemedReactContext, pipParamsBuilder: PictureInPictureParams.Builder, autoEnterEnabled: Boolean) {
-        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.S) return
+    fun applyAutoEnterEnabled(context: ThemedReactContext, pipParamsBuilder: PictureInPictureParams.Builder?, autoEnterEnabled: Boolean) {
+        if (pipParamsBuilder == null || Build.VERSION.SDK_INT < Build.VERSION_CODES.S) return

It also seems that NullPointerException can be thrown by other PictureInPictureUtil.apply* methods.

[bae-unidev]

@YangJonghun

I completely agree with your approach to reduce the complexity of ReactExoplayerView by moving branching logic into PictureInPictureUtil. I’ve updated applyAutoEnterEnabled and other similar methods in PictureInPictureUtil to handle null checks directly and ensure NPE safety.

[YangJonghun]

LGTM😁

[KrzysztofMoch]

Thanks!