Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tvOS): fix tvos compile error #4369

Merged
merged 2 commits into from
Jan 18, 2025
Merged

fix(tvOS): fix tvos compile error #4369

merged 2 commits into from
Jan 18, 2025

Conversation

YangJonghun
Copy link
Collaborator

  • Provide an example of how to test the change
    Compile properly with tvOS application

  • Describe the changes
    Create meaningless RCTPictureInPicture class

fix #4365

@YangJonghun YangJonghun self-assigned this Jan 13, 2025
@YangJonghun
Copy link
Collaborator Author

AFAIK, PIP support has been available since tvOS 14.
It would be nice to see tvOS support added one day.🙏

@mykhailodanilenko mykhailodanilenko mentioned this pull request Jan 16, 2025
Closed
@freeboub freeboub merged commit 6c3af99 into TheWidlarzGroup:master Jan 18, 2025
6 checks passed
@YangJonghun YangJonghun deleted the fix/tvos-compile-err branch January 24, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

Assignees

@YangJonghun YangJonghun

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: 6.9 has compile errors when compiling for tvOS
3 participants
@YangJonghun @freeboub @KrzysztofMoch