Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for code scanning alert no. 4: Server-side request forgery #91

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 4: Server-side request forgery #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a563ec9
Potential fix for code scanning alert no. 4: Server-side request forgery
Ushcode Feb 14, 2025
4a80a1d
Merge remote-tracking branch 'origin/main' into alert-autofix-4
Ushcode Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions code/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,23 @@ app.prepare().then(() => {
console.info('GeoServer requests from MapBox will be sent to ' + process.env.REACT_APP_SERVER_URL + '/geoserver-proxy')
server.get('/geoserver-proxy', keycloak.protect(), async (req, res) => {
const targetUrl = req.query.url;
const allowedUrls = [
'https://example.com/geoserver',
'https://another-allowed-url.com/geoserver'
];

let headers = { ...req.headers };

if (req.kauth?.grant) {
headers['Authorization'] = 'Bearer ' + req.kauth.grant.access_token.token;
}

try {
// Validate the target URL against the allowed list
if (!allowedUrls.includes(targetUrl)) {
return res.status(400).send('Invalid URL');
}

// Forward the request to the target URL with the modified headers
const response = await axios({
url: targetUrl,
Expand Down
Loading