-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hactoolnet: Add NPDM converter #255
base: master
Are you sure you want to change the base?
Conversation
Nice, this is something that should have been added to hactoolnet a while ago since hactool already has it. How does the output compare to that of hactool? I know it's a simple question that I could test myself, but I've had my time taken up by other things over the past few weeks |
Hactool does have a set format for the |
Alright, I just re-worked the whole output method to result in a file similar to the ones described above. I've annotated the problems I'm having with it (version missing, multiple MMIO and IRQs), but other than that, it's now outputting a file of the exact same format as |
"Version" is the "ProcessCategory" field. It was incorrectly called the latter in the past, while the former is the correct name. LibHac still uses the latter, incorrect name. |
c2ccd67
to
e50cba9
Compare
Okay, fixed that - now it's only unknown what to do with multiple MMIOs and IRQs, and what happens with a |
Why does the CI fail here? |
Apparently the CI as it's set up has trouble pulling version information when it's someone other than a repo owner makes a PR |
Alright, so I can safely ignore that I guess... could you look over this PR again and annotate stuff you'd want to have changed? I'd love to get this merged ... some time. |
Sure, is it ready to go now? It was apparently a WIP last time I looked at it since it wasn't working then |
Following the command line interface of
hactool
,npdm
files should be convertable tojson
for easier inspection. As there is no set format on how thosejson
files should look, I just decided to read in the file and dump the whole internal structure into ajson
file by using.NET
sJsonSerializer
, beautifying things on the way by adding indentation.