New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cannot access a chrome url #63

Merged

juskek merged 11 commits into main from fix/Cannot-access-a-chrome-URL

Jul 27, 2023

Contributor

juskek commented Jul 26, 2023 •

edited

Loading

Removed async in onMessage callback so that sendResponse works:
Show error if user tries to calculate on a chrome:// URL
Refactored mockChrome to avoid callback hell

juskek added 6 commits

July 26, 2023 12:14


          fix:remove async from onMessage.addListener

16e54ec


          fix: check if on chrome:// page in background process before attachin…

4a62b84

…g debugger


          fix:do not go to RecordingPage if chrome URL, show alert

82c949d


          fix:do not go to RecordingPage if chrome URL

ea32cd5


          test: change mocks to avoid callback hell

19bc8b9


          Merge branch 'fix/Cannot-access-a-chrome-URL' of https://github.com/T…

e44ed4d

…heodo-UK/sustainability-calculator into fix/Cannot-access-a-chrome-URL

Francisco-Costa98 reviewed

View reviewed changes

src/background/background.ts Show resolved Hide resolved

Francisco-Costa98 reviewed

View reviewed changes

src/background/background.ts Outdated Show resolved Hide resolved

Francisco-Costa98 reviewed

View reviewed changes

src/background/background.ts Outdated Show resolved Hide resolved

Francisco-Costa98 reviewed

View reviewed changes

src/background/background.ts Outdated Show resolved Hide resolved

Francisco-Costa98 reviewed

View reviewed changes

src/background/background.ts Outdated Show resolved Hide resolved

Francisco-Costa98 reviewed

View reviewed changes

src/view/popup/popup.tsx Show resolved Hide resolved

Francisco-Costa98 reviewed

View reviewed changes

src/view/popup/popup.tsx

@@ @@ -69,8 +70,9 @@ export const Popup = () => { @@
                           ) : page === "results" ? (
                               <ResultsPage
                                   onRestartButtonPress={async () => {
-                                      goToPage("recording");
-                                      await refreshAndGetSize();
+                                      if (await refreshAndGetSize()) {

Contributor

Francisco-Costa98 Jul 26, 2023

same here

Francisco-Costa98 reviewed

View reviewed changes

src/view/popup/usePopup.ts Show resolved Hide resolved

Francisco-Costa98 reviewed

View reviewed changes

src/view/popup/utils/backgroundStopRecordingBytes.ts Outdated Show resolved Hide resolved


          chore: created background helpers for readability

b1fd535

juskek force-pushed the fix/Cannot-access-a-chrome-URL branch from 8f81d0b to b1fd535 Compare

July 27, 2023 08:58

juskek added 4 commits

July 27, 2023 10:00


          chore: created background helpers for readability

5b74463


          chore: rename tabId for readability

59de02a


          Merge branch 'fix/Cannot-access-a-chrome-URL' of https://github.com/T…

b0dfc32

…heodo-UK/sustainability-calculator into fix/Cannot-access-a-chrome-URL


          chore: improve readability for debugginProtocolVersion

b8f81ab

juskek merged commit ee0b746 into main

juskek mentioned this pull request

fix: rename tabId with activeTabId #64

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet