-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Use counter for group macros #108
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
@Mike-MF Are you interested in this? Do I update it? |
eh, It's a lot of work I'd just close it |
I mean, not really. just a preference thing |
I like it, it simplifies things. |
Feel free, might be placebo but using ranks more "correctly" seems to actually affect how quickly group leaders change with less downtime on AI actually doing stuff. Added it into the macro below how it is currently, hopefully it's right as I'm still mostly asleep.
|
Personally I prefer this as you don't need to declare a macro for each, don't need to worry about calling them in the correct order, although you do need to call
__COUNTER_RESET__
at the startDepends on #107 because I was using a dev build of HEMTT that doesn't like the current master. Looks like current HEMTT also doesn't like
__COUNTER_RESET__
for some reason.(This PR will look better once #107 is on master)