Dynamic addition of particles #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a bigger buffer than necessary + store a u32 to know the actual number of particles Not working yet.
ThierryBerger
force-pushed
the
dynamic_add_particles
branch
from
1932085 to
0fbcbfd
Compare
ThierryBerger
commented
Apr 18, 2025
Owner
Author
There was a problem hiding this comment.
rename with postfix 2
ThierryBerger
commented
Apr 18, 2025
| phase: None, | ||
| color: None, | ||
| }; | ||
| particles.push(particle_proto); |
Owner
Author
There was a problem hiding this comment.
todo: fix bug where we access particles[0]
ThierryBerger
commented
Apr 18, 2025
| particle.position += vector![1.0, 0.0] * (i as f32) * cell_width * 1.1; | ||
| physics.push_particle(queue, &particle); | ||
| } | ||
| physics.reset_graphics = true; |
Owner
Author
There was a problem hiding this comment.
todo: cleaner way to update graphics with same strategy.
ThierryBerger
commented
Apr 18, 2025
| mut materials: ResMut<Assets<BevyMaterial>>, | ||
| to_clear: Query<Entity, With<InstanceMaterialData>>, | ||
| ) { | ||
| if physics_context.reset_graphics { |
Owner
Author
There was a problem hiding this comment.
add comment warnign about performance if we merge as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a bigger buffer than necessary + store a u32 to know the actual number of particles
Current status
Working 🎉 ; some polishing to do: