fix(updateNode): fix empty string embeddings bug

ThinAirThings · Apr 15, 2024 · 5ea5538 · 5ea5538
1 parent 3975da7
commit 5ea5538
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/functions/updateNodeFactory.ts b/src/functions/updateNodeFactory.ts
@@ -63,7 +63,7 @@ export const updateNodeFactory = <
                         nextNodeProperties[key as keyof TypeOf<PD>] !== null &&
                         nextNodeProperties[key as keyof TypeOf<PD>] !== ''
                     )
-            const embeddingsMap = embeddingsDefinitionKeys && await openai.embeddings.create({
+            const embeddingsMap = embeddingsDefinitionKeys && embeddingsDefinitionKeys.length && await openai.embeddings.create({
                 model: embeddingsModel,
                 input: embeddingsDefinitionKeys.map((key) => {
                     const { contextPointer, gptModel } = embeddingsDefinition[key as keyof typeof embeddingsDefinition]!

diff --git a/src/testing.ts b/src/testing.ts
@@ -98,8 +98,12 @@ const {
 })
 
 
-const newJobNode = await createNode('Company', {
-    'companyName': 'Blueprint2',
+const companyNode = await createNode('Company', {
+    'companyName': 'Blueprint6',
+})
+const out = await updateNode('Company', companyNode!.nodeId, {
+    'logo': 'https://fdsfsd.com',
+    'shortDescription': ''
 })
 // console.log(newJobNode)
 // const updatedNode = await updateNode('Job', newJobNode!.nodeId, (nodeState) => {