feat: allow Connector's addresses to be relative URLs #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up until now,
Addresses
were required to include the origin (e.g.,https://my.edc.example.com/api/check/health
), but it become impractical when we want to implement a UI with proxy on the same origin (e.g.,/api/check/health
).This ability allow the URL to be relative, enabling the use case mentioned above.
How to test it
Added a test to ensure failure is coming from the HTTP request, and not from the URL construction. Since relative URLs work only in the browser, I wouldn't know how to test this without bringing in a new e2e setup (e.g., using playwright or cypress)
Approach
Rather then constructing the URL via
new URL(...)
and then adding query parameters to the instance, URL is simply a concatenation of two strings – the "baseUrl" (or relative path) and the resource path), appending at the end the query params added to a newly instance ofURLSearchParams
: