feat: use v3 asset endpoints and drop deprecated v2 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
approved these changes
Aug 8, 2023
| method: "POST", | ||
| apiToken: context.apiToken, | ||
| body: { | ||
| ...input, | ||
| "@context": this.defaultContextValues, | ||
| }, | ||
| }) | ||
| .then(body => expand(body, () => new IdResponse())); | ||
| .then((body) => expand(body, () => new IdResponse())); |
There was a problem hiding this comment.
just a question, why do we put brackets also when there's only a parameter?
There was a problem hiding this comment.
This is done automatically by my linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to resolve #48
How to test it
All tests should be passing successfully.
Approach
I had to make some updates on entities because a few of them changed in the
v3expected inputs.I also dropped the data address endpoints and the old asset ones because they are now deprecated.