refactor: split controllers #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
reviewed
Aug 8, 2023
src/facades/management.ts
Outdated
| this.#inner = inner; | ||
| } | ||
|
|
||
| get assetController() { |
There was a problem hiding this comment.
I would drop the Controller word from these getters, so then the expression to, e.g. create an asset would be:
management.asset.create(...).
Maybe also adding the s could reflect the "rest resource" concept, becoming:
management.assets.create(...)
|
@ndr-brt do you feel like we should also split tests exactly like we did for the sub controllers? |
@OlfaBensoussia definitely! |
OlfaBensoussia
force-pushed
the
refactor/reorganize-management-controllers
branch
from
962554a to
7cbf48e
Compare
OlfaBensoussia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to resolve #42
When looking at this issue, I thought about two ways to address it.
The first is to do it through dependency injection. The idea was to create a global interface for controllers, and then inject controllers into the new management class. The second one is to simply get inspiration from the facade design pattern, and have one class that wraps all of the other controllers through a simplified interface where we create instances of these controller classes. I went for the latter and would like to hear your opinions @ndr-brt @fdionisi
How to test it
Approach
Open Questions and Pre-Merge TODOs
Learning