Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove compacted representation #82

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

ndr-brt
Copy link
Contributor

@ndr-brt ndr-brt commented Sep 1, 2023

Description

The new "jsonld" version fixed a bug for which we needed to keep the compacted jsonld representation.
This PR removes it.

Notes

  • did some minor refactorings
  • added the nested method on JsonLdObject, that permits to "navigate" into a json object
  • added a dedicated test class for dataplane controller (before these tests were located in the transfer process one

Closes #81

@ndr-brt ndr-brt force-pushed the 81-remove-compacted-representation branch from 01c422f to 704c8c9 Compare September 1, 2023 07:47
@ndr-brt ndr-brt force-pushed the 81-remove-compacted-representation branch from 704c8c9 to 4c41f23 Compare September 1, 2023 07:49
@ndr-brt ndr-brt marked this pull request as ready for review September 1, 2023 07:50
@ndr-brt ndr-brt mentioned this pull request Sep 1, 2023
Copy link
Member

@fdionisi fdionisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@ndr-brt ndr-brt merged commit b96e81d into main Sep 4, 2023
@ndr-brt ndr-brt deleted the 81-remove-compacted-representation branch September 4, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "compacted" representation from jsonld object
2 participants