Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define criterion right operand as any #89

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

ndr-brt
Copy link
Contributor

@ndr-brt ndr-brt commented Sep 4, 2023

Description

Define CriterionInput operandRight as any, because it could be an arrays of string or a free form object, e.g.:

{
  "operandLeft": "id",
  "operator": "in",
  "operandRight": ["1", "2"]
}

notes

  • separated Criterion from CriterionInput
  • minor refactorings

Copy link
Member

@fdionisi fdionisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue we are solving here?

@ndr-brt
Copy link
Contributor Author

ndr-brt commented Sep 6, 2023

whops, forgot to add details 🥲

@ndr-brt ndr-brt requested a review from fdionisi September 6, 2023 16:45
Copy link
Member

@fdionisi fdionisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I better understand. Thank you, Andrea.

These changes fit the needs, but I'd like to see how we can strongly type the library in the future. Perhaps a developer experience/tech debt issue to open as a follow-up. Would that work?

Nevertheless, great job!

@ndr-brt
Copy link
Contributor Author

ndr-brt commented Sep 7, 2023

Now I better understand. Thank you, Andrea.

These changes fit the needs, but I'd like to see how we can strongly type the library in the future. Perhaps a developer experience/tech debt issue to open as a follow-up. Would that work?

Nevertheless, great job!

I'm not sure, it depends from what direction we want to follow, as a criterion for a right argument we could theoretically accept every kind of object, so any looks fine to me (in the EDC codebase in java we are using Object).

@ndr-brt ndr-brt merged commit f7a57ac into main Sep 7, 2023
@ndr-brt ndr-brt deleted the 88-criterion-rightoperand-any branch September 7, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants