-
Notifications
You must be signed in to change notification settings - Fork 1
feat(rst): add glacier support #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swartzn
wants to merge
8
commits into
main
Choose a base branch
from
swartzn/add-glacier-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39cb377 to
7a29032
Compare
|
@swartzn Squash commits before merging |
dbcd5f0 to
294dd70
Compare
294dd70 to
3afcac2
Compare
8b36f0c to
d1854e5
Compare
swartzn
commented
Oct 23, 2025
d1854e5 to
e5d4ba6
Compare
a53ddea to
010690c
Compare
63c143d to
e0c9087
Compare
5a857ba to
e748d00
Compare
e0c9087 to
b1dad7e
Compare
1a58355 to
a8b1024
Compare
b1dad7e to
ef4f20e
Compare
iamjoemccormick
requested changes
Oct 29, 2025
Rescheduled requests only traversed when at least one is ready.
a1b5873 to
45aeb6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: Add help text for the new parameters to the bottom of this file. I don't mind helping with this, just adding a comment so we don't forget it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, this PR's basic glacier/archival functionality is ready for review but I intend to make a few more minor improvements.
What does this PR do / why do we need it?
Required for all PRs.
Add support for s3-compatible archival storage classes which require restoring the resource before downloading it.
Note ThinkParQ/protobuf#54 is required.
Related Issue(s)
Required when applicable.
Where should the reviewer(s) start reviewing this?
Only required for larger PRs when this may not be immediately obvious.
Are there any specific topics we should discuss before merging?
Not required.
What are the next steps after this PR?
Not required.
Checklist before merging:
Required for all PRs.
When creating a PR these are items to keep in mind that cannot be checked by GitHub actions:
For more details refer to the Go coding standards and the pull request process.