Skip to content

Conversation

@swartzn
Copy link
Contributor

@swartzn swartzn commented Jul 1, 2025

FYI, this PR's basic glacier/archival functionality is ready for review but I intend to make a few more minor improvements.

What does this PR do / why do we need it?

Required for all PRs.

Add support for s3-compatible archival storage classes which require restoring the resource before downloading it.

Note ThinkParQ/protobuf#54 is required.

Related Issue(s)

Required when applicable.

Where should the reviewer(s) start reviewing this?

Only required for larger PRs when this may not be immediately obvious.

Are there any specific topics we should discuss before merging?

Not required.

What are the next steps after this PR?

Not required.

Checklist before merging:

Required for all PRs.

When creating a PR these are items to keep in mind that cannot be checked by GitHub actions:

  • Documentation:
    • Does developer documentation (code comments, readme, etc.) need to be added or updated?
    • Does the user documentation need to be expanded or updated for this change?
  • Testing:
    • Does this functionality require changing or adding new unit tests?
    • Does this functionality require changing or adding new integration tests?
  • Git Hygiene:

For more details refer to the Go coding standards and the pull request process.

@swartzn swartzn requested a review from a team as a code owner July 1, 2025 19:14
@swartzn swartzn force-pushed the swartzn/add-glacier-support branch from 39cb377 to 7a29032 Compare July 2, 2025 19:11
@swartzn swartzn changed the base branch from main to swartzn/add-priority-wait-queue July 7, 2025 10:27
@swartzn swartzn self-assigned this Aug 4, 2025
@swartzn
Copy link
Contributor Author

swartzn commented Aug 4, 2025

@swartzn Squash commits before merging

@swartzn swartzn force-pushed the swartzn/add-priority-wait-queue branch from dbcd5f0 to 294dd70 Compare August 25, 2025 10:49
@swartzn swartzn force-pushed the swartzn/add-priority-wait-queue branch from 294dd70 to 3afcac2 Compare September 24, 2025 16:06
@swartzn swartzn force-pushed the swartzn/add-glacier-support branch from 8b36f0c to d1854e5 Compare October 23, 2025 12:27
@swartzn swartzn force-pushed the swartzn/add-glacier-support branch from d1854e5 to e5d4ba6 Compare October 24, 2025 17:11
@swartzn swartzn force-pushed the swartzn/add-priority-wait-queue branch 2 times, most recently from a53ddea to 010690c Compare October 25, 2025 21:40
@swartzn swartzn force-pushed the swartzn/add-glacier-support branch 3 times, most recently from 63c143d to e0c9087 Compare October 28, 2025 14:19
@swartzn swartzn force-pushed the swartzn/add-priority-wait-queue branch from 5a857ba to e748d00 Compare October 28, 2025 14:42
@swartzn swartzn force-pushed the swartzn/add-glacier-support branch from e0c9087 to b1dad7e Compare October 28, 2025 14:43
@swartzn swartzn force-pushed the swartzn/add-priority-wait-queue branch 2 times, most recently from 1a58355 to a8b1024 Compare October 28, 2025 19:39
Base automatically changed from swartzn/add-priority-wait-queue to main October 28, 2025 19:43
@swartzn swartzn force-pushed the swartzn/add-glacier-support branch from b1dad7e to ef4f20e Compare October 28, 2025 23:55
@swartzn swartzn changed the title Swartzn/add glacier support feat(rst): add glacier support Oct 28, 2025
@swartzn swartzn force-pushed the swartzn/add-glacier-support branch from a1b5873 to 45aeb6e Compare October 29, 2025 18:34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: Add help text for the new parameters to the bottom of this file. I don't mind helping with this, just adding a comment so we don't forget it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants