chore/refactor: upgrade to Go 1.25, adopt new tools directive, address feedback on migration error, fix entry pkg static checks #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify migration cannot reuse targets already assigned to the entry. * Address static checks QF1003, ST1000, ST1003, ST1020, and ST1021 in the ctl/entry package. * Remove unused context parameter.
iamjoemccormick
added
refactoring
The upgrade from 1.23 was prompted by new standard library vulnerabilities in that version and the desire to adopt the new tools directive introduced in Go 1.24. The tools directive ensures that all Go-based tools (e.g. staticcheck, go-licenses, govulncheck) are built with the same toolchain and versions defined by the module, rather than with whichever binaries happen to exist in GOPATH/bin. This prevents confusing errors that can occur after upgrading Go or switching environments and makes tool execution fully reproducible in CI. Also fixes a new go vet failure (non-constant format string in fmt.Errorf).
iamjoemccormick
changed the title
iamjoemccormick
changed the title
iamjoemccormick
added
ci/cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why do we need it?
Required for all PRs.
This PR was originally opened to improve a migration error and fix up some low priority static checks flagged in the vicinity.
After pushing those changes I realized there were new standard library vulnerabilities so I took the opportunity to upgrade to Go 1.25.3 and also migrate to the new tools directive. Using the tools directive ensures all Go tools (e.g. staticcheck, go-licenses, govulncheck) are built with the same toolchain and versions defined by the module, rather than whatever binaries happen to exist in GOPATH/bin. This avoids confusing errors like that can occur after upgrading Go or switching environments, and makes tool execution fully reproducible in CI.
Related Issue(s)
Required when applicable.
Where should the reviewer(s) start reviewing this?
Only required for larger PRs when this may not be immediately obvious.
Are there any specific topics we should discuss before merging?
Not required.
What are the next steps after this PR?
Not required.
Checklist before merging:
Required for all PRs.
When creating a PR these are items to keep in mind that cannot be checked by GitHub actions:
For more details refer to the Go coding standards and the pull request process.