Skip to content

feat: Add support for returning metadata root mirror node info #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

feat: Add support for returning metadata root mirror node info #18

merged 1 commit into from
Jul 11, 2025

Conversation

@sundereshwar
Copy link
Contributor

@sundereshwar sundereshwar commented Jul 4, 2025 •
edited
Loading

  • Extend SQL in query_row_cached to pull buddy‐group’s group_id, group_uid and `alias.
  • Introduce a second Option<EntityIdSet> (now named meta_root_mirror) alongside `meta_root_node.
  • Match on nullable mirror columns so that if group_id and uid exist, we build the EntityIdSet (alias defaults to empty)

ThinkParQ/beegfs-go#27

The changes required in the protobuf have been made in this PR:
ThinkParQ/protobuf#55

@sundereshwar sundereshwar self-assigned this Jul 4, 2025
@sundereshwar sundereshwar requested a review from a team as a code owner July 4, 2025 08:24
@sundereshwar sundereshwar requested a review from rustybee42 July 4, 2025 08:24
rustybee42
rustybee42 reviewed Jul 7, 2025
View reviewed changes
@sundereshwar sundereshwar requested a review from rustybee42 July 8, 2025 05:43
rustybee42
rustybee42 reviewed Jul 8, 2025
View reviewed changes
@sundereshwar sundereshwar requested a review from rustybee42 July 9, 2025 07:06
rustybee42
rustybee42 reviewed Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@rustybee42 rustybee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good now, except for missing formatting (see the comment).

And you need to update the protobuf dependency, now that has been merged.

@sundereshwar sundereshwar requested a review from rustybee42 July 10, 2025 11:14
@sundereshwar sundereshwar force-pushed the sunder/root-meta-mirror-flag branch from f86d789 to f6b0234 Compare July 11, 2025 11:35
@sundereshwar
feat: Add support for returning metadata root mirror node info and ot…
25a502e 
…her refactors

- Extended SQL query and added root mirror node support
- Refactored variable names and queries
- Updated dependencies and formatting

ThinkParQ/beegfs-go#27
@sundereshwar sundereshwar force-pushed the sunder/root-meta-mirror-flag branch from f6b0234 to 25a502e Compare July 11, 2025 11:42
@sundereshwar sundereshwar merged commit 8be8517 into main Jul 11, 2025
4 checks passed
@sundereshwar sundereshwar deleted the sunder/root-meta-mirror-flag branch July 11, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rustybee42 rustybee42 rustybee42 approved these changes

Assignees

@sundereshwar sundereshwar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sundereshwar @rustybee42