Skip to content

Conversation

@rustybee42
Copy link
Collaborator

Similar to the servers in https://github.com/ThinkParQ/beegfs-core/pull/4369

Also fix broadcasting of UDP messages which before would abort on a send failure instead of just dumping the message to all known addresses. Now only debug logs and only errors if all sends failed.

@rustybee42 rustybee42 self-assigned this Sep 2, 2025
@rustybee42 rustybee42 force-pushed the rb/ipv6-followup branch 2 times, most recently from 1d7af88 to ca74b99 Compare September 2, 2025 12:53
Also fix broadcasting of UDP messages which before would abort on a send
failure instead of just dumping the message to all known addresses. Now
only debug logs and only errors if all sends failed.
@rustybee42 rustybee42 marked this pull request as ready for review September 2, 2025 14:33
@rustybee42 rustybee42 requested a review from a team as a code owner September 2, 2025 14:33
iamjoemccormick
iamjoemccormick previously approved these changes Sep 2, 2025
Copy link
Member

@iamjoemccormick iamjoemccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a few optional suggestions.

Note I didn't get a chance to test the IPv4 fallback when IPv6 is completely disabled, but the logic looks sound and I know that is already being tested by others.

@rustybee42 rustybee42 merged commit 14b6851 into main Sep 4, 2025
4 checks passed
@rustybee42 rustybee42 deleted the rb/ipv6-followup branch September 4, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants