Skip to content

Conversation

@rustybee42
Copy link
Collaborator

Implement the same checks as in beegfs-core to have similar behavior: If dual stack is disabled (or ipv6 is enabled during boot but disabled at runtime), fall back to ipv4.

@rustybee42 rustybee42 requested a review from a team as a code owner September 8, 2025 13:07
@rustybee42 rustybee42 self-assigned this Sep 8, 2025
@rustybee42 rustybee42 changed the title fix: Fall back to ipv4 if dual stack sockets are disabled Fall back to ipv4 if dual stack sockets are disabled Sep 8, 2025
@rustybee42 rustybee42 force-pushed the rb/ipv6-followup-2 branch 2 times, most recently from 14642e4 to 0e3925b Compare September 10, 2025 09:58
@rustybee42 rustybee42 enabled auto-merge (squash) September 22, 2025 12:30
@rustybee42 rustybee42 disabled auto-merge September 22, 2025 12:31
Copy link
Member

@iamjoemccormick iamjoemccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions, but I'll leave it up to you if these things are important to resolve or if the code is robust enough as is.

Copy link
Member

@iamjoemccormick iamjoemccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to hit "approve" instead of "request changes" because I don't consider my feedback blocking.

@rustybee42 rustybee42 merged commit ad9585e into main Sep 24, 2025
4 checks passed
@rustybee42 rustybee42 deleted the rb/ipv6-followup-2 branch September 24, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants