Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for upcoming ggplot2 update #11

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix test for upcoming ggplot2 update #11

merged 1 commit into from
Feb 8, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break shinipsum.

Briefly, testing that the length of a ggplot object is length 9 is brittle for changes in ggplot2 itself. This PR updates the expectation of the test to the lame length as a ggplot object, rather than exactly 9.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help shinipsum get out a fix if necessary.

@teunbrand
Copy link
Contributor Author

This is a kind reminder that the release of ggplot2 is scheduled soon.

@ColinFay ColinFay merged commit 27aabb2 into ThinkR-open:master Feb 8, 2024
1 check failed
@ColinFay
Copy link
Member

ColinFay commented Feb 8, 2024

Thanks a lot ! will send to CRAN :)

@teunbrand teunbrand deleted the ggplot2_3.5.0 branch February 8, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants