Newsletter Thinkmill opt-in checkboxes + fix light button spinner #3627
Annotations
10 errors and 6 warnings
TypeScript:
design-system/pkg/src/action-bar/ActionBar.tsx#L163
Type '((key: import("/home/runner/work/keystatic/keystatic/node_modules/.pnpm/@react-types+shared@3.22.1_react@18.2.0/node_modules/@react-types/shared/src/key").Key) => void) | undefined' is not assignable to type '((key: React.Key) => void) | undefined'.
|
TypeScript:
design-system/pkg/src/action-bar/ActionBarContainer.tsx#L45
Type 'ForwardRefExoticComponent<ActionBarContainerProps & DOMProps & RootStyleProps & { margin?: Responsive<LooseSizeSpace> | undefined; ... 34 more ...; zIndex?: Responsive<...> | undefined; } & RefAttributes<...>>' is not assignable to type 'ForwardRefExoticComponent<ActionBarContainerProps & DOMProps & RootStyleProps & { margin?: Responsive<LooseSizeSpace> | undefined; ... 34 more ...; zIndex?: Responsive<...> | undefined; } & { ...; }>'.
|
TypeScript:
design-system/pkg/src/avatar/Avatar.tsx#L49
Type 'ForwardRefExoticComponent<AvatarProps & RefAttributes<HTMLDivElement>>' is not assignable to type 'ForwardRefExoticComponent<AvatarProps & { ref?: Ref<HTMLDivElement> | undefined; }>'.
|
TypeScript:
design-system/pkg/src/badge/Badge.tsx#L43
Type 'ForwardRefExoticComponent<{ children: ReactNode; tone?: BadgeTones | undefined; } & RootStyleProps & { margin?: Responsive<LooseSizeSpace> | undefined; ... 34 more ...; zIndex?: Responsive<...> | undefined; } & DOMProps & AriaLabelingProps & RefAttributes<...>>' is not assignable to type 'ForwardRefExoticComponent<{ children: ReactNode; tone?: BadgeTones | undefined; } & RootStyleProps & { margin?: Responsive<LooseSizeSpace> | undefined; ... 34 more ...; zIndex?: Responsive<...> | undefined; } & DOMProps & AriaLabelingProps & { ...; }>'.
|
TypeScript:
design-system/pkg/src/button/ButtonGroup.tsx#L79
Type 'ForwardRefExoticComponent<{ align?: "center" | "end" | "start" | undefined; children: ReactNode; isDisabled?: boolean | undefined; orientation?: Orientation | undefined; } & DOMProps & RootStyleProps & { ...; } & RefAttributes<...>>' is not assignable to type 'ForwardRefExoticComponent<{ align?: "center" | "end" | "start" | undefined; children: ReactNode; isDisabled?: boolean | undefined; orientation?: Orientation | undefined; } & DOMProps & RootStyleProps & { ...; } & { ...; }>'.
|
TypeScript:
design-system/pkg/src/button/FieldButton.tsx#L21
Type 'ForwardRefExoticComponent<PropsWithElementType<FieldButtonProps> & RefAttributes<HTMLButtonElement>>' is not assignable to type 'ForwardRefExoticComponent<FieldButtonProps & { ref?: Ref<HTMLButtonElement> | undefined; }>'.
|
TypeScript:
design-system/pkg/src/button/ToggleButton.tsx#L24
Type 'ForwardRefExoticComponent<ToggleButtonProps & RefAttributes<HTMLButtonElement>>' is not assignable to type 'ForwardRefExoticComponent<ToggleButtonProps & { ref?: Ref<HTMLButtonElement> | undefined; }>'.
|
TypeScript:
design-system/pkg/src/contextual-help/ContextualHelp.tsx#L22
Type 'ForwardRefExoticComponent<{ children: ReactNode; placement?: Placement | undefined; variant?: "help" | "info" | undefined; } & OverlayTriggerProps & PositionProps & ... 4 more ... & RefAttributes<...>>' is not assignable to type 'ForwardRefExoticComponent<{ children: ReactNode; placement?: Placement | undefined; variant?: "help" | "info" | undefined; } & OverlayTriggerProps & PositionProps & ... 4 more ... & { ...; }>'.
|
TypeScript:
design-system/pkg/src/dialog/AlertDialog.tsx#L24
Type 'React.ForwardRefExoticComponent<{ tone?: "critical" | "neutral" | undefined; title: string; children: React.ReactNode; cancelLabel?: string | undefined; primaryActionLabel: string; secondaryActionLabel?: string | undefined; ... 5 more ...; autoFocusButton?: "cancel" | ... 2 more ... | undefined; } & import("/home/ru...' is not assignable to type 'React.ForwardRefExoticComponent<{ tone?: "critical" | "neutral" | undefined; title: string; children: React.ReactNode; cancelLabel?: string | undefined; primaryActionLabel: string; secondaryActionLabel?: string | undefined; ... 5 more ...; autoFocusButton?: "cancel" | ... 2 more ... | undefined; } & import("/home/ru...'. Two different types with this name exist, but they are unrelated.
|
TypeScript:
design-system/pkg/src/dialog/Dialog.tsx#L48
Type 'ForwardRefExoticComponent<{ children: ReactNode; size?: DialogSize | undefined; isDismissable?: boolean | undefined; onDismiss?: (() => void) | undefined; } & { role?: "dialog" | "alertdialog" | undefined; } & ... 4 more ... & RefAttributes<...>>' is not assignable to type 'ForwardRefExoticComponent<{ children: ReactNode; size?: DialogSize | undefined; isDismissable?: boolean | undefined; onDismiss?: (() => void) | undefined; } & { role?: "dialog" | "alertdialog" | undefined; } & ... 4 more ... & { ...; }>'.
|
TypeScript
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Linting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Linting:
design-system/pkg/src/toast/test/Toast.test.tsx#L117
Some tests seem to be commented
|
Tests (2)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Tests (1)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|