Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] - Hide branches management UI #751

Closed
wants to merge 4 commits into from
Closed

[Feat] - Hide branches management UI #751

wants to merge 4 commits into from

Conversation

Barruchou
Copy link

Following this discussion on Discord:

https://discord.com/channels/1139017922073866332/1139017922895937598/1170003038942003210

Here is a PR to allow you to hide branch management elements from the interface.

Copy link

changeset-bot bot commented Nov 13, 2023

⚠️ No Changeset found

Latest commit: a954bd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
keystatic-site ✅ Ready (Inspect) Visit Preview Nov 14, 2023 2:16pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
keystar-ui ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:16pm
keystatic ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:16pm
keystatic-next-blocks-builder ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 2:16pm

@jossmac
Copy link
Member

jossmac commented Nov 15, 2023

This will break core functionality. For example, if there's branch protection on main and a user is prompted to create a new branch they'll be stranded with no way to navigate.

branch protection dialog

@Barruchou
Copy link
Author

Hello @jossmac

There is no config to change the default branch (other than "main")? In this case it would leave the developer the choice to have a "content" branch (for example) and continue to protect his "main" branch. Or allow you to define a fallback branch which would be used in the case of a protected "main".

What do you think ?

@jossmac
Copy link
Member

jossmac commented Nov 15, 2023

Hi @Barruchou, sorry I meant "default branch" but said main so it aligned with the screenshot. We'll look into an approach that allows consumers to configure a "content branch" or similar, but simply hiding UI that breaks functionality isn't a viable solution.

@jossmac jossmac closed this Nov 15, 2023
@jossmac
Copy link
Member

jossmac commented Nov 15, 2023

This is something we'd like to explore, if there's community interest. @Barruchou could you create a discussion?

@Barruchou
Copy link
Author

And here it is: #759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants