Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: incorrect type defs #110

Merged
merged 3 commits into from
Sep 10, 2021
Merged

chore: incorrect type defs #110

merged 3 commits into from
Sep 10, 2021

Conversation

maraisr
Copy link
Contributor

@maraisr maraisr commented Sep 9, 2021

This package imports a type from a file not defined in the package.

import { PackageJSON } from "@changesets/types";

May I suggest including depcheck to avoid this in the future?

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2021

⚠️ No Changeset found

Latest commit: 8bbdb77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maraisr
Copy link
Contributor Author

maraisr commented Sep 9, 2021

Friendly bump @Andarist @mitchellhamilton

@Andarist
Copy link
Collaborator

Andarist commented Sep 9, 2021

May I suggest including depcheck to avoid this in the future?

This package is built using Preconstruct and it already comes with a "variant" of the dep check, unfortunately - it only validates runtime dependencies. I think the type-only deps are kinda ignored by it. Having that improved would be a nice addition to the Preconstruct

@maraisr
Copy link
Contributor Author

maraisr commented Sep 9, 2021

In any case, it's a dep that sound be added to the package json. Mind helping me here?

@emmatown emmatown merged commit c521941 into Thinkmill:master Sep 10, 2021
@maraisr maraisr deleted the patch-1 branch September 10, 2021 04:14
@maraisr
Copy link
Contributor Author

maraisr commented Sep 10, 2021

@mitchellhamilton @Andarist dang forgot to push up a changesets, like me to PR a subsequent one?

@emmatown
Copy link
Member

that would be great

@github-actions github-actions bot mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants