-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: incorrect type defs #110
Conversation
|
Friendly bump @Andarist @mitchellhamilton |
This package is built using Preconstruct and it already comes with a "variant" of the dep check, unfortunately - it only validates runtime dependencies. I think the type-only deps are kinda ignored by it. Having that improved would be a nice addition to the Preconstruct |
In any case, it's a dep that sound be added to the package json. Mind helping me here? |
@mitchellhamilton @Andarist dang forgot to push up a changesets, like me to PR a subsequent one? |
that would be great |
This package imports a type from a file not defined in the package.
manypkg/packages/get-packages/src/index.ts
Line 9 in 24cf582
May I suggest including
depcheck
to avoid this in the future?