Change external mismatch check & fix to most common #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Thinkmill#117 When a developer adds a new dependency, npm/yarn will add the newest version of the dependency. We want manypkg to fix that newest version to the most commonly used version in the repo, since it is unlikely that a developer adding a new dependency to a package also intends to update the whole repo. If the dependency ranges for a dependency all occur once, it will fix to the highest version.
🦋 Changeset detectedLatest commit: df618d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mitchellhamilton This should be ready for review. I hadn't thought of the edge-case where all ranges are used the same amount of times, but it was relatively easy to cover off that edge-case, it did lead to me needing a lot more extra tests though. |
emmatown
approved these changes
Oct 28, 2021
Merged
|
how do I use the previous behavior? I was able to fix one dependency and manypkg would do the rest in a large monorepo. is there a flag or argument to |
|
You can use the upgrade command for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #117
When a developer adds a new dependency, npm/yarn will add the
newest version of the dependency. We want manypkg to fix that newest
version to the most commonly used version in the repo, since it is
unlikely that a developer adding a new dependency to a package also
intends to update the whole repo.
If the dependency range for a dependency all occur once, it will
fix to the highest version.