Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): absolute cwd path matched workspace exclude rules (#121) #122

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Nov 4, 2021

fix #121

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2021

🦋 Changeset detected

Latest commit: b9fbc79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@manypkg/cli Patch
@manypkg/get-packages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very interesting fix - do you know why this has fixed the mentioned issue? How do those two things relate to each other. I would expect the absolute: true to only normalize the final output and not to affect what actually gets matched.

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@fz6m
Copy link
Contributor Author

fz6m commented Nov 8, 2021

It's a very interesting fix - do you know why this has fixed the mentioned issue? How do those two things relate to each other. I would expect the absolute: true to only normalize the final output and not to affect what actually gets matched.

In fast-glob (globby based on fast-glob). If absolute is specified as true :

so first resolve path, then start matching regexp.

like this, start with ! regexp requires an additional cwd path. but this prefix path is not in the pnpm worksapces rules.

@emmatown emmatown merged commit 7bd4f34 into Thinkmill:master Nov 9, 2021
@github-actions github-actions bot mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getPackages method not working on cwd absolute path matches the pnpm workspace exclude rules
3 participants