Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Upgrade to Properly Update Scoped Packages #206

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

bdkopen
Copy link
Contributor

@bdkopen bdkopen commented Apr 13, 2024

Issue

Running manypkg upgrade @scope currently upgrades packages formatted as @scope/package and @scope-extra/package. This is problematic because it should not be updating @scope-extra/ packages.

Solution

Properly upgrade package so manypkg upgrade @scope only upgrades @scope/ packages and manypkg upgrade @scope-extras only upgrades @scope-extras/ packages.

Related

Copy link

changeset-bot bot commented Apr 13, 2024

🦋 Changeset detected

Latest commit: 0e3c0d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@manypkg/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@Andarist Andarist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (cc @emmatown ). If this doesn't get an extra review within a week - please feel free to ping me and I'll land it then.

@emmatown emmatown merged commit c2c4a3b into Thinkmill:main Apr 14, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Apr 14, 2024
@bdkopen
Copy link
Contributor Author

bdkopen commented Apr 14, 2024

Thanks @Andarist and @emmatown!

Should #148 and #175 be closed now that this is released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants