[dependencies-replacement] Replace spawndamnit with tinyexec (8 fewer dependencies)

[VanTanev]

First PR addressing #221.

https://github.com/tinylibs/tinyexec is used by vitest, so it should be a fairy safe bet.

[changeset-bot]

🦋 Changeset detected

Latest commit: d9d1649

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@manypkg/cli	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Andarist]

Could u refactor the touched lines to this style (when possible)?

Suggested change

	const proc = exec(args[0], args.slice(1), {
	const { exitCode } = await exec(args[0], args.slice(1), {

or at least to this if the .exitCode! is problematic:

Suggested change

	const proc = exec(args[0], args.slice(1), {
	const result = await exec(args[0], args.slice(1), {

[VanTanev]

Unfortunately, the exec() constructor and the return type of the await proc are different types.

const proc = exec() is an object that holds a "prepared execution" that you can attach streams/events/whatever on. It is also .then()-able, but that returns a different object...
const result = await proc is a Result type that only has stdout and stderr. It doesn't have exitCode (though I think it really should, there is an issue upstream, will see if I can open a PR for it).

The proc.exictCode! should be correct, because exitCode should always be set if we have awaited the proc.

As weird as the code looks right now, it is the only way to write it as far as I can see.

[Andarist]

Let's wait a little bit then before landing this. It would be great if exitCode thing would be improved upstream.

[VanTanev]

Oh, I was holding it wrong!

When the process has an non-zero exit code, an exception is thrown.

This means that if we don't read stdout/stderr, we can just do:

    await exec("yarn", args.slice(1), {
      nodeOptions: {
        cwd: matchingPackages[0].dir,
        stdio: "inherit",
      },
    });

And we can completely remove the ExitError class, as tinyexec throws its own NonZeroExitError.

I'll update the PR and ping you.

[VanTanev]

Merged the upstream change in tinyexec: tinylibs/tinyexec#38

The PR is now good for re-review.

[Andarist]

why do we need to treat a nullish exitCode as a failure here?

[VanTanev]

Per node:child_proccess.spawn(), exitCode can be nullish in 2 cases:

• The process failed to spawn.
• The process was externally killed.

For our purpose, both of these mean that the underlying process never executed successfully, so we should treat a missing exit code as an error.

[Andarist]

😍