[dependencies-replacement] Replace fs-extra with node:fs/promises #225
Conversation
🦋 Changeset detectedLatest commit: 2677110 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
VanTanev
force-pushed
the
dependencies-replace-fs-extra
branch
from
5b4f44f
to
1e12490
Compare
| @@ -17,7 +17,6 @@ | |||
| "chalk": "^2.4.2", | |||
| "detect-indent": "^6.0.0", | |||
| "find-up": "^4.1.0", | |||
| "fs-extra": "^8.1.0", | |||
There was a problem hiding this comment.
ugh, I've missed it but we might also want to drop this:
Line 32 in d0f4d92
There was a problem hiding this comment.
I'll add it to one of the next ones.
Wanted to add knip to catch stuff like this, but even though it's a dev dependency, it requires node 18.18. If we're fine with removing the engines field in the monrepo root?
There was a problem hiding this comment.
Hm, yee - the monorepo root doesn't have to maintain that node version compat. Although I guess having the engines there makes it easier to control stuff right now. But well, I'd still be OK with removing it from there and making sure it's in all other package.json of our publishable packages
For #221 - removes 4 dependencies