-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noviny/update gatsby source workspaces #35
Conversation
26cb770
to
a6d9caf
Compare
version: String | ||
dir: String | ||
relativeDir: String | ||
packageJSON: JSON! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need commands for test-gatsby added in a package somewhere?
Otherwise, just questions and nitpicks. LGTM
extraFields: [ | ||
{ | ||
name: "readme", | ||
definition: `String`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why definition
here and not type
? Where are these types coming from? The graphql spec? Gatsby? TS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm I answered my own question https://www.gatsbyjs.org/docs/actions/#createTypes
@@ -1,4 +1,6 @@ | |||
const findWorkspacesRoot = require("find-workspaces-root").default; | |||
const fs = require("fs-extra"); | |||
const path = require("path"); | |||
|
|||
// Funfact, all gatsby code and example code uses template literlas instead of | |||
// strings - see if you can figure out the places I copy/pasted code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this comment serve a purpose? 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entertainment value?
There's a script to start it in It's worth calling out that this package's construction has quite a bit of fast + loose about it, such as:
I haven't chose to address these things here, or look at other repo-level concerns. It's possible this is important enough that we want it as a ticket? |
No description provided.