Improve heuristic to determine when it is necessary to fetch an id

.changeset/smart-weeks-kiss.md

@@ -0,0 +1,5 @@
+---
+"@ts-gql/eslint-plugin": patch
+---
+
+Improve heuristic to determine when it is necessary to fetch an id

.vscode/settings.json

@@ -0,0 +1,5 @@
+{
+  "editor.codeActionsOnSave": {
+    "source.fixAll.eslint": false
+  }
+}

packages/eslint-plugin/src/parse.ts

@@ -135,7 +135,7 @@ export function handleTemplateTag(
   visit(
     ast,
     visitWithTypeInfo(typeInfo, {
-      SelectionSet(selectionSetNode) {
+      SelectionSet(selectionSetNode, key, parent) {
         let type = typeInfo.getType();
         if (!type) {
           throw new Error(
@@ -155,7 +155,6 @@ export function handleTemplateTag(
             type = type.ofType;
           }
         }
-
         if (
           !(
             type instanceof GraphQLInterfaceType ||
@@ -178,14 +177,36 @@ export function handleTemplateTag(
             "Location not found for selection. This is an internal error. If you see this, this is most likely a bug in ts-gql"
           );
         }
+        let selectionSetAlreadyHasId = selectionSetNode.selections.some(
+          (x) => x.kind === "Field" && x.name.value === "id"
+        );
+        if (selectionSetAlreadyHasId) {
+          return;
+        }
+        let isOnlyFragmentSpread = selectionSetNode.selections.every(
+          (x) => x.kind === "FragmentSpread"
+        );
+        if (isOnlyFragmentSpread) {
+          return;
+        }
 
         if (
-          type.getFields()["id"] &&
-          !selectionSetNode.selections.some(
-            (x) => x.kind === "Field" && x.name.value === "id"
-          ) &&
-          !selectionSetNode.selections.every((x) => x.kind !== "Field")
+          parent &&
+          !Array.isArray(parent) &&
+          (parent as any).kind === "InlineFragment"
         ) {
+          let parentType = (typeInfo as any)._parentTypeStack[
+            (typeInfo as any)._parentTypeStack.length - 2
+          ];
+          if (
+            parentType instanceof GraphQLInterfaceType &&
+            parentType.getFields().id
+          ) {
+            return;
+          }
+        }
+
+        if (type.getFields().id) {
           let fixPosition =
             selectionSetNode.loc?.start + node.quasi.range[0] + 2;
           let fixText =

test-app/pages/apollo.tsx

@@ -20,6 +20,12 @@ const someFragment = gql`
       id
       other
     }
+    thing {
+      id
+      ... on ImplementationOfThing {
+        something
+      }
+    }
   }
 ` as import("../__generated__/ts-gql/Something2Apollo_x").type;
 

test-app/schema.graphql

@@ -5,6 +5,7 @@ type Query {
   something: String
   someObj: OutputThing!
   arr: [OutputThing!]!
+  thing: Thing!
   optional(thing: String): String!
   oneMore(thing: String, other: Something!): String!
 }
@@ -18,6 +19,15 @@ type Mutation {
   oneMore(thing: String, other: Something!): String!
 }
 
+interface Thing {
+  id: ID!
+}
+
+type ImplementationOfThing implements Thing {
+  id: ID!
+  something: String!
+}
+
 type OutputThing {
   id: ID!
   other: String!