Merge #3825

3825: fix (Invoicing Bug) r=jniles a=lomamech

- resolution of the problem when calling the Debtors.balance function
with rounding to two ranks after the decimal point of the total credit and
debit values

closes #3822

Co-authored-by: Chris Lomame <lomamech@gmail.com>

server/controllers/finance/debtors/index.js

@@ -261,10 +261,16 @@ function balance(debtorUuid, excludeCautionLinks = false) {
 
   const excludeCautionLinkStatement = `AND transaction_type_id <> ${CAUTION_LINK_TYPE_ID}`;
 
+  /**
+   * resolution of the problem when calling the Debtors.balance function with
+   * rounding to two ranks after the decimal point of the total credit and
+   * debit values
+   *
+   */
   const sql = `
     SELECT IFNULL(SUM(ledger.debit_equiv), 0) AS debit, IFNULL(SUM(ledger.credit_equiv), 0) AS credit,
-      IFNULL(SUM(ledger.debit_equiv - ledger.credit_equiv), 0) AS balance, MIN(trans_date) AS since,
-      MAX(trans_date) AS until
+    IFNULL(SUM(ledger.debit_equiv - ledger.credit_equiv), 0) AS balance, MIN(trans_date) AS since,
+    MAX(trans_date) AS until
     FROM (
       SELECT debit_equiv, credit_equiv, entity_uuid, trans_date FROM posting_journal
         WHERE entity_uuid = ? ${excludeCautionLinks ? excludeCautionLinkStatement : ''}

server/controllers/finance/patientInvoice.js

@@ -204,7 +204,7 @@ function create(req, res, next) {
   // so, we will use their caution balance to link to the invoice for payment.
   Debtors.balance(invoice.debtor_uuid)
     .then(([pBalance]) => {
-      const hasCreditorBalance = hasPrepaymentSupport && pBalance && (pBalance.credit > pBalance.debit);
+      const hasCreditorBalance = hasPrepaymentSupport && pBalance && ((pBalance.credit - pBalance.debit) > 0.01);
       const preparedTransaction = createInvoice(invoice, hasCreditorBalance, prepaymentDescription);
       return preparedTransaction.execute();
     })