chore(reports): remove stock-changes report

This commit removes the stock_changes report, useful only for manual stock calculations and never implemented in practice. The same functionality (keeping track of stock offline) has been implemented in the BHIMA Stock Android application. Closes #7103.
Third-Culture-Software · Jul 24, 2023 · ab1a506 · ab1a506
1 parent 0559a5e
commit ab1a506
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 217 deletions.
diff --git a/client/src/modules/reports/generate/stock_changes/stock_changes.config.js b/client/src/modules/reports/generate/stock_changes/stock_changes.config.js
diff --git a/client/src/modules/reports/generate/stock_changes/stock_changes.html b/client/src/modules/reports/generate/stock_changes/stock_changes.html
diff --git a/client/src/modules/reports/reports.routes.js b/client/src/modules/reports/reports.routes.js
@@ -45,7 +45,6 @@ angular.module('bhima.routes')
       'recovery_capacity',
       'rumer_report',
       'satisfaction_rate_report',
-      'stock_changes',
       'stock_consumption_graph_report',
       'stock_entry',
       'stock_exit',

diff --git a/server/config/routes.js b/server/config/routes.js
@@ -889,7 +889,6 @@ exports.configure = function configure(app) {
   app.get('/reports/stock/lost', stockReports.lostStockReport);
   app.get('/reports/stock/movement_report', stockReports.movementReport);
   app.get('/reports/stock/expiration_report', stockReports.expirationReport);
-  app.get('/reports/stock/changes', stockReports.stockChangesReport);
 
   app.get('/reports/stock/lots', stockReports.stockLotsReport);
   app.get('/reports/stock/movements', stockReports.stockMovementsReport);

diff --git a/server/controllers/stock/reports/index.js b/server/controllers/stock/reports/index.js
@@ -41,7 +41,6 @@ const stockValue = require('./stock/value');
 const stockAssignmentReceipt = require('./stock/assignment/stock_assign.receipt');
 const stockAssignReport = require('./stock/assignment/stock_assign.registry');
 const stockRequisitionReceipt = require('../requisition/requisition.receipt');
-const stockChangesReport = require('./stock/stock_changes/stock_changes');
 const lotBarcodeReceipt = require('./stock/lot_barcode/lot_barcode');
 
 /**
@@ -167,7 +166,6 @@ exports.purchasePrices = require('./purchase_prices');
 
 exports.lotBarcodeReceipt = lotBarcodeReceipt;
 exports.lostStockReport = lostStockReport;
-exports.stockChangesReport = stockChangesReport;
 exports.stockAdjustmentReceipt = stockAdjustmentReceipt;
 exports.stockExitAggregateConsumptionReceipt = stockExitAggregateConsumptionReceipt;
 

diff --git a/server/controllers/stock/reports/stock/stock_changes/stock_changes.js b/server/controllers/stock/reports/stock/stock_changes/stock_changes.js
diff --git a/server/models/bhima.sql b/server/models/bhima.sql
@@ -153,7 +153,6 @@ INSERT INTO unit VALUES
   (289, 'Stock Expiration report','TREE.STOCK_EXPIRATION_REPORT','Stock expiration report', 282,'/reports/stock_expiration_report'),
   (290, '[SETTINGS] Settings', 'TREE.STOCK_SETTINGS', 'Stock Settings', 160, '/stock/setting'),
   (291, 'Stock Dashboard', 'TREE.STOCK_DASHBOARD','Stock Dashboard', 160,'/stock/dashboard'),
-  (292, 'Stock Changes Report', 'REPORT.STOCK_CHANGES.TITLE', 'Stock Changes Report', 282, '/reports/stock_changes'),
   (293, 'Aggregated consumption','TREE.AGGREGATED_STOCK_CONSUMPTION','Aggregated consumption', 160,'/stock/aggregated_consumption'),
   (294, 'Duplicate Lots','TREE.DUPLICATE_LOTS','The stock lots duplicates list', 160,'/stock/lots/duplicates'),
   (295, 'Rumer report','TREE.RUMER_REPORT','The rumer reports', 282,'/reports/rumer_report'),
@@ -242,7 +241,6 @@ INSERT IGNORE INTO `report` (`report_key`, `title_key`) VALUES
   ('recovery_capacity', 'REPORT.RECOVERY_CAPACITY.TITLE'),
   ('rumer_report', 'REPORT.RUMER.TITLE'),
   ('satisfaction_rate_report', 'TREE.SATISFACTION_RATE_REPORT'),
-  ('stock_changes', 'REPORT.STOCK_CHANGES.TITLE'),
   ('stock_consumption_graph_report', 'REPORT.STOCK_CONSUMPTION_GRAPH_REPORT.TITLE'),
   ('stock_entry', 'REPORT.STOCK.ENTRY_REPORT'),
   ('stock_exit', 'REPORT.STOCK.EXIT_REPORT'),
@@ -584,4 +582,3 @@ VALUES
     (15, 'REAM', 1),
     (16, 'SACK', 1),
     (17, 'SET', 1);
-
diff --git a/server/models/migrations/next/migrate.sql b/server/models/migrations/next/migrate.sql
@@ -1 +1,5 @@
-/* v1.28.x */
+/* v1.28.x */
+
+-- remove references to stock_changes report
+DELETE FROM unit WHERE `path` = '/reports/stock_changes';
+DELETE FROM report where `report_key` = 'stock_changes';