New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Complex Vouchers #2196

Closed

jniles opened this issue Oct 12, 2017 · 1 comment · Fixed by #7386

Assignees

Labels

Collaborator

jniles commented Oct 12, 2017 •

edited

Loading

The following improvements need to be made the Complex Vouchers:

~~Use a typeahead for accounts instead of a ui-select. This will improve the performance of the page and also be the same style as the transaction editing modal.~~ Fixed: Inline an account typeahead for Complex Vouchers #2226.
Allow a user to link the debtor/creditors and references by typing, as in the Transaction Edit Modal. Most users will probably prefer this to scrolling through millions of lines to find their particular transaction. We could still include the modal behind a double click.
The debtor/creditor selection shouldn't require a user to select "debtor/creditor". It might be easiest to just have an entity/ route that allows a typeahead to fill with both based on the input. We would label each with a [D] or [C] depending on the type.
Remove the "Recover Items" since it doesn't work.
~~The transaction type should automatically focus itself. At the moment, it doesn't focus the input when a user clicks on it.~~
~~[BUG] submitting a form without any rows in the grid results in an empty error message.~~

The text was updated successfully, but these errors were encountered:

jniles added Bug Refactor labels

Collaborator Author

jniles commented Oct 25, 2017

Note: the inline typeahead of addressed in #2226.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): show error on empty grid

bbcc0e3

This commit blocks submission of a complex voucher when there are no
items in the grid.  Previously, this logic was skipped .. it has been
moved further up in the chain to make sure that it gets called.

Partially addresses Third-Culture-Software#2196.

jniles mentioned this issue

fix(vouchers): complex voucher form glitches #2255

Merged

bors bot added a commit that referenced this issue


          Merge #2255

2255: fix(vouchers): complex voucher form glitches r=mbayopanda a=jniles

This commit implements the ui-select autofocus hack on the complex voucher's ui-select.  When the dropdown is clicked, the input is now selected.

Closes #1957.

This commit blocks submission of a complex voucher when there are no
items in the grid.  Previously, this logic was skipped .. it has been
moved further up in the chain to make sure that it gets called.

Partially addresses #2196.

jniles self-assigned this

jniles mentioned this issue

Overhaul Complex Vouchers interface #3553

Closed

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

f803153

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

0eb3dc7

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

a304806

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

bbcd44f

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles mentioned this issue

Improvements to complex vouchers #7386

Merged

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

18ca579

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

ba75765

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

3f5bbad

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

aede27d

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

eafbd2b

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

8270ded

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

f23ec70

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

39a5920

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

7feb9c2

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

762f645

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

69fb0f3

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

586bfc3

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          fix(vouchers): remove the recover cache button

315e004

This commit removes the recover cache button as requested in Third-Culture-Software#2196.

Close Third-Culture-Software#2196.

jniles added a commit to jniles/bhima that referenced this issue


          chore: rm findReferenceModel, findEntityModal

023da36

This commit removes the findReferenceModal and findEntityModals since
they are no longer used.  Also cleans up all associated code and
unnecessary formatting.

Closes Third-Culture-Software#2196.

jmcameron closed this as completed in #7386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment