Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bhDateInterval doesn't set correctly dates #4017

Closed
mbayopanda opened this issue Nov 25, 2019 · 3 comments · Fixed by #4018
Closed

bhDateInterval doesn't set correctly dates #4017

mbayopanda opened this issue Nov 25, 2019 · 3 comments · Fixed by #4018
Assignees
@jeremielodi
Labels
in progress

Comments

@mbayopanda
Copy link
Collaborator

This issue is about the fact that :

  • For the week, the bhDateInterval doesn't set correctly the end date (current date is 2019-11-25)
    image

  • For the month, the bhDateInterval doesn't set correctly the end date (current date is 2019-11-25)
    image

  • For the year, the bhDateInterval doesn't set correctly the end date (current date is 2019-11-25)
    image
@jniles
Copy link
Collaborator

jniles commented Nov 25, 2019

Should it set the end date to today or to the end of the search period? What is the expected behavior?

@jeremielodi jeremielodi self-assigned this Nov 25, 2019
jeremielodi added a commit to jeremielodi/bhima-2.X that referenced this issue Nov 25, 2019
@jeremielodi
Refractor(bhdateInterval) set correct dates
0ab1c68 
closes Third-Culture-Software#4017
@jeremielodi jeremielodi mentioned this issue Nov 25, 2019
Merged
@mbayopanda
Copy link
Collaborator Author

@jniles the expected behavior is :

  • When we click on this month for example, we must have the start date set to 2019-11-01 and the end date set to 2019-11-30, but with the bug we have 2019-12-01 instead of 2019-11-30

@jniles
Copy link
Collaborator

jniles commented Nov 25, 2019

Aha, okay, I understand what you are going for.

jeremielodi added a commit to jeremielodi/bhima-2.X that referenced this issue Nov 25, 2019
@jeremielodi
Refractor(bhdateInterval) set correct dates
7ecbf7d 
closes Third-Culture-Software#4017
jeremielodi added a commit to jeremielodi/bhima-2.X that referenced this issue Nov 25, 2019
@jeremielodi
Refractor(bhdateInterval) set correct dates
58fa626 
closes Third-Culture-Software#4017
jeremielodi added a commit to jeremielodi/bhima-2.X that referenced this issue Nov 25, 2019
@jeremielodi
Refractor(bhdateInterval) set correct dates
3349d6e 
closes Third-Culture-Software#4017
jeremielodi added a commit to jeremielodi/bhima-2.X that referenced this issue Nov 25, 2019
@jeremielodi
Refractor(bhdateInterval) set correct dates
84ffd2b 
closes Third-Culture-Software#4017
jeremielodi added a commit to jeremielodi/bhima-2.X that referenced this issue Nov 25, 2019
@jeremielodi
Refractor(bhdateInterval) set correct dates
34395b7 
closes Third-Culture-Software#4017
bors bot added a commit that referenced this issue Nov 27, 2019
@bors @jeremielodi
Merge #4018
8415ed8 
4018: Refractor(bhdateInterval) set correct dates r=mbayopanda a=jeremielodi

closes #4017

Co-authored-by: jeremielodi <jeremielodi@gmail.com>
@bors bors bot closed this as completed in d5c2fe7 Nov 27, 2019
mbayopanda added a commit to mbayopanda/bhima that referenced this issue Nov 30, 2019
@mbayopanda
The BHIMA release 1.8.0
6c8da27 
This release includes :
- Third-Culture-Software#4022 : Harmonize stock receipts headers
- Third-Culture-Software#4017 : Refactor the bhDateInterval
- Third-Culture-Software#4010, Third-Culture-Software#4004 : Enhance the depot registry with filters
- Third-Culture-Software#4007 : Setting up cloud-init configuration for bhima
- Third-Culture-Software#3990 : Improve vouchers from stock movements
@mbayopanda mbayopanda mentioned this issue Nov 30, 2019
Merged
bors bot added a commit that referenced this issue Nov 30, 2019
@bors @mbayopanda
Merge #4030
eae59d2 
4030: The BHIMA release 1.8.0 r=jniles a=mbayopanda

This release includes :
- #4022 : Harmonize stock receipts headers
- #4017 : Refactor the bhDateInterval
- #4010, #4004 : Enhance the depot registry with filters
- #4007 : Setting up cloud-init configuration for bhima
- #3990 : Improve vouchers from stock movements

Co-authored-by: mbayopanda <mbayopanda@gmail.com>
bors bot added a commit that referenced this issue Nov 30, 2019
@bors @mbayopanda
Merge #4030
f3a8f84 
4030: The BHIMA release 1.8.0 r=jniles a=mbayopanda

This release includes :
- #4022 : Harmonize stock receipts headers
- #4017 : Refactor the bhDateInterval
- #4010, #4004 : Enhance the depot registry with filters
- #4007 : Setting up cloud-init configuration for bhima
- #3990 : Improve vouchers from stock movements

Co-authored-by: mbayopanda <mbayopanda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremielodi jeremielodi

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refractor(bhdateInterval) set correct dates jeremielodi/bhima-2.X
4 participants
@jniles @mbayopanda @jeremielodi @kwilu