Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(proposal) Replace user.first and user.last with user.display_name #617

Closed
jniles opened this issue Aug 3, 2016 · 4 comments
Closed

(proposal) Replace user.first and user.last with user.display_name #617

jniles opened this issue Aug 3, 2016 · 4 comments
Assignees
Labels

Comments

@jniles
Copy link
Collaborator

jniles commented Aug 3, 2016

I propose that we replace the user.first and user.last names with user.display_name that will appear on reports. This is much less confusing and gives the user control over the way the name is displayed (first, middle, last OR last, first, middle).

@IMA-WorldHealth/local-contributors what do you think?

@jniles jniles added the Refactor label Aug 3, 2016
@jniles jniles added this to the Future milestone Aug 3, 2016
@sfount
Copy link
Contributor

sfount commented Aug 3, 2016

I agree - this should also be uniform across all tables that we record a name (potentially with patients as an exception).

For example, some different naming schemes we have currently:

Employees - employee.prenom employee.name employee.postnom
Users - user.first user.last
Suppliers - supplier.name
Patients - patient.first_name patient.middle_name patient.last_name

@jniles
Copy link
Collaborator Author

jniles commented Aug 3, 2016

@sfount, thanks for the feedback. Those are good observations - I think we could update most of these tables with display_name to lower confusion. We can schedule this as a refactor due sometime.

@jniles
Copy link
Collaborator Author

jniles commented Aug 25, 2016

@lomamech, could you work on this issue while waiting for a review on #669?

@jniles
Copy link
Collaborator Author

jniles commented Sep 1, 2016

Closed in #676.

@jniles jniles closed this as completed Sep 1, 2016
jniles referenced this issue in jniles/bhima Sep 7, 2016
This commit improves the cash receipt by:
 1. Fixing the enterprise location rendering
 2. Rendering the correct display_name (broken in #617)
 3. Show the exchange rate when appropriate.
jniles referenced this issue in jniles/bhima Sep 7, 2016
This commit improves the cash receipt by:
 1. Fixing the enterprise location rendering
 2. Rendering the correct display_name (broken in #617)
 3. Show the exchange rate when appropriate
 4. Show the payment id on the receipt
 5. Show the debtor's ID on the receipt
 6. Better signature rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants