Adding print functionality

[lomamech]

Adding print functionality

Update bhBreadcrumb.js component for adding property print
Update template for breadCrumb with the using of bh-breadcrumb
Implement patient invoice report in PDF
Update inventory list, voucher registry for Prevent modale windows
Adding route for manage invoice / patient / report

@jniles

[jniles]

This code is the exact same code as the patientInvoice list() function. Since it is a duplication, I propose that you use the same function.

I propose that you make a new function in the patientInvoice file called listInvoices(). You could then write:

// GET /invoices
function list(req, res, next) {
  listInvoices()
  .then(function (invoices) {
    res.status(200).json(invoices);
  })
  .catch(next)
  .done();
}

// GET /invoices/patient/report
function getPatientInvoice(req, res, next) {

  const request = { /* some values */ };

  listInvoices()
  .then(invoices => listReceipt.build(invoices, request):
   // ... etc ...
  })
  .catch(next)
  .done();
}

Remember, in software engineering, we don't like to repeat ourselves.

[jniles]

@lomamech I've completed an initial code review. Thanks for taking the time to work all this out.

Here are some additional comments outside the code.

1. When I use the application, I notice some things that are poor quality. For example, the buttons are different sizes. See below:

   
   Fig 1: Different Sized Buttons?
   Please make all the buttons the same size. I propose you remove the btn-sm classes in the bhBreadCrumb component.

2. The two reports, Invoice Registry and Voucher Registry, are in two different orientations. They both contain about the same amount of information. Why are they in two different orientations? I propose that they both be in portrait orientation. See below:

   
   Fig 2: Landscaped Invoices
   
   Fig 3: Portrait Vouchers

Let me know if you need any clarification or when you need another review.

[lomamech]

• Using the function listInvoices in controllers/finance/patientInvoice.js
• Put currency_id in filter for the currency
• Sanitaze the reports invoices
• Sanitaze code
• Fix the size of button
• Update the orientation remplace landscape by portrait
• Resolve conflict with branch Master

@jniles

[lomamech]

Hello @jniles
All tests integrations and end to end work very well
Let me know what works not
Thank you

[jniles]

@lomamech, the tests do not pass on Node versions less than v6.

The error you are receiving is due to missing 'use strict' in one of the files you changed to use let or const. See this answer.