Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird total in footer on vouchers registry #6262

Closed
jniles opened this issue Jan 10, 2022 · 0 comments · Fixed by #6267
Closed

Weird total in footer on vouchers registry #6262

jniles opened this issue Jan 10, 2022 · 0 comments · Fixed by #6267
Assignees
@lomamech
Labels
user interface

Comments

@jniles
Copy link
Collaborator

jniles commented Jan 10, 2022

What do you suppose this total is for? Are we summing the transaction type_ids of the vouchers?

image

If so, we should just remove this code.
@lomamech lomamech mentioned this issue Jan 11, 2022
Merged
bors bot added a commit that referenced this issue Jan 11, 2022
@bors @lomamech
Merge #6267
cddd292 
6267: improvement(Voucher Registry) r=jniles a=lomamech

- Remove not necessary summing in column type_id and amount

closes #6262

Co-authored-by: lomamech <lomamech@gmail.com>
@bors bors bot closed this as completed in 5cbbf5f Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomamech lomamech

Labels
user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement(Voucher Registry) lomamech/bhima-2.X
2 participants
@jniles @lomamech