-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(i18n): refactor en.json key #3155
Merged
bors
merged 3 commits into
Third-Culture-Software:master
from
AdamWatts:refactor-cash-missing-debtor-error-text
Sep 7, 2018
Merged
chore(i18n): refactor en.json key #3155
bors
merged 3 commits into
Third-Culture-Software:master
from
AdamWatts:refactor-cash-missing-debtor-error-text
Sep 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice @AdamWatts! Looks like the tests pass muster online. We'll post a suitable translation and then get this merged 👍 |
@jniles Nice, Thank you :) |
@mbayopanda, can you provide a French translation for this change? |
Beautiful. Thanks to both of you! bors r+ |
Build succeeded |
Delete the branch? |
Sure! It won't harm anything. |
@AdamWatts Congrats on closing your first issue! 🎉 |
@sfount Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue
Closes #3100