Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): refactor en.json key #3155

Conversation

AdamWatts
Copy link
Contributor

@AdamWatts AdamWatts commented Sep 7, 2018

For issue

Closes #3100

@jniles jniles added the Refactor label Sep 7, 2018
@jniles
Copy link
Collaborator

jniles commented Sep 7, 2018

Nice @AdamWatts! Looks like the tests pass muster online. We'll post a suitable translation and then get this merged 👍

@AdamWatts
Copy link
Contributor Author

@jniles Nice, Thank you :)

@jniles
Copy link
Collaborator

jniles commented Sep 7, 2018

@mbayopanda, can you provide a French translation for this change?

@jniles
Copy link
Collaborator

jniles commented Sep 7, 2018

Beautiful. Thanks to both of you!

bors r+

bors bot added a commit that referenced this pull request Sep 7, 2018
3155: chore(i18n): refactor en.json key r=jniles a=AdamWatts

For issue 

Closes #3100

Co-authored-by: Adam Watts <adamt.watts@gmail.com>
Co-authored-by: mbayopanda <mbayopanda@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 7, 2018

Build succeeded

@bors bors bot merged commit b655104 into Third-Culture-Software:master Sep 7, 2018
@AdamWatts
Copy link
Contributor Author

Delete the branch?

@jniles
Copy link
Collaborator

jniles commented Sep 7, 2018

Sure! It won't harm anything.

@sfount
Copy link
Contributor

sfount commented Sep 7, 2018

@AdamWatts Congrats on closing your first issue! 🎉

@AdamWatts
Copy link
Contributor Author

@sfount Thanks for the help!

@AdamWatts AdamWatts deleted the refactor-cash-missing-debtor-error-text branch September 7, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants