chore: remove req.codes + unused dependencies #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit completely removes `req.codes`. All errors are handled in a single error handler that returns errors with three consumable properties: 1. code 2. description 3. stack Database errors are handled automatically, returned as `BadRequest` errors. Any more specificity should be handled via custom interceptors instead of simply calling `next()`. Closes #287.
This commit collapses the two $http configuration functions into a single function during the application startup process. Eventually AuthInjector should probably be deprecated and removed.
This commit removes budget routes from the routes.js file and removes the budget controller until a proper server design is submitted for the budget controller.
This commit is a critical fix to make sure the test scripts only kill the process they started, rather than all node processes globally. This had the side effect of killing any other node instances, including `npm` downloads and `node-gyp` builds. It has been fixed.
|
Very useful standardisation! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the server by removing the
req.codesfile from the repository and unifying error handling in a single function that returns objects with three consumable properties:Database errors are handled automatically, returned as
BadRequesterrors. Any more specificity should be handled via custom interceptors instead of simply callingnext().Additionally, the client-side error handles are now configured in the same place. This is achieved by collapsing the two $http configuration functions into a single function during the application startup process. Eventually
AuthInjectorshould probably be deprecated and removed.Finally, removes unused dependencies
fast-csvandconnect-multiparty.Additionally, this PR includes a really handy improvement to the test shell scripts, ensuring they only kill processes they create, rather than all node process in general. This is a good step in helping to speed up our testing and ensuring no conflicts occur with concurrent builds/installations.
Closes #75 and #287.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process
and help build a stronger application. Thanks!