Feat(inventory) download log as excel #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jniles
reviewed
Nov 18, 2019
| unit_weight : 'FORM.LABELS.WEIGHT', | ||
| }; | ||
|
|
||
| const dictionary = util.loadDictionary(lang); |
| @@ -38,6 +38,10 @@ | |||
| </div> | |||
| </div> | |||
| <div class="modal-footer"> | |||
| <a target='_blank' class="btn btn-primary" data-method="close" href="/inventory/download/log/{{$ctrl.inventory.uuid}}?lang={{$ctrl.lang}}"> | |||
There was a problem hiding this comment.
The data-method=close will confuse our end to end tests. Could you remove it?
| // get inventory log as excel | ||
| // GET /inventory/download/log/:uuid?rendere=xlsx?lang=fr | ||
|
|
||
| async function logDownLoad(req, res, next) { |
There was a problem hiding this comment.
It would be nice to have an integration test for this functionality, to at least show it still works. Could you write one?
|
|
||
| lines.push({ | ||
| column1 : _.get(dictionary, 'FORM.LABELS.INVENTORY'), | ||
| column2 : inventory[0].label || '', |
There was a problem hiding this comment.
Is there ever a case where inventory[0].label won't be defined? If so, what happens?
jeremielodi
force-pushed
the
inventory_log-download
branch
2 times, most recently
from
e86bc5f to
5d5e50f
Compare
jniles
reviewed
Nov 20, 2019
| @@ -88,6 +95,76 @@ function inventoryLog(req, res, next) { | |||
| }).catch(next); | |||
| } | |||
|
|
|||
| // get inventory log as excel | |||
| // GET /inventory/download/log/:uuid?rendere=xlsx?lang=fr | |||
There was a problem hiding this comment.
This URL doesn't match what the actual URL is. Can you change the parameters to reflect that?
| it('GET /inventory/download/log/?lang=fr donwload log as Ms excel', () => { | ||
| return agent.get(`/inventory/download/log/${inventoryUuid}?lang=fr`) | ||
| .then(res => { | ||
| expect(res).to.have.status(200); |
There was a problem hiding this comment.
Could you check the content type to make sure it is the correct content type?
|
@jeremielodi can you make the changes to this PR for it it be merged? |
jeremielodi
force-pushed
the
inventory_log-download
branch
2 times, most recently
from
64554bd to
912edae
Compare
jeremielodi
force-pushed
the
inventory_log-download
branch
from
912edae to
934b07d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3976