chore: run eslint --fix on server files #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit runs `eslint --fix` on server files and manually patches issues that cannot be fixed automatically.
jniles
force-pushed
the
chore-apply-eslint-fixes-to-server-files
branch
from
19297fa to
bd0e66f
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2020
4131: deps: bump package versions r=jniles a=jniles Bumps some major package versions so that they are up to date. Notably, this includes: 1. `mkdirp` 2. `mocha` 3. `cross-env` Additionally, I've removed lzma-native since it sometimes causes crashes on windows and replaced it with the native zlib. This also fits into our regular backup strategy. Closes #4126. Closes #4127. Closes #4129. 4132: chore: run eslint --fix on server files r=jniles a=jniles This commit runs `eslint --fix` on server files and manually patches issues that cannot be fixed automatically. Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit runs
eslint --fixon server files and manually patches issues that cannot be fixed automatically.