fix(reports): stock expiration report #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the stock expiration report by doing the following
things:
1. Removes the date range as these don't make any sense.
2. Uses the same colorscheme as used in the other reports for
warning/danger text.
3. Adds total summaries to the top of the report.
4. Removes the inventory select.
5. Simplifies the queries so that less for loops are done.
6. Fixes the currency bug so things render in the enterprise currency.
7. Adds the column for the unit type.
Closes Third-Culture-Software#4835.
jniles
force-pushed
the
4835-fix-stock-expiration-report
branch
from
fb2c6fc to
8135d8a
Compare
lomamech
approved these changes
Sep 16, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the stock expiration report by doing the following
things:
Closes #4835.
Here is what it looks like now:
I chose not to implement the "total value in stock" since this would be a rather expensive query and probably only makes sense if we are looking at a single depot at a time.