Add page for finding and merging duplicate lots

[jmcameron]

Create a page where operators can find and merge potential duplicate lots.

Note that this PR adds a new page under the Stock navigation menu: "Find Duplicate Lots". In order to use or test this, be sure to edit the user role permissions and enable the new page (under the Stock section).

Closes #5166

Testing

• Use a production database such as IMCK
• Start Bhima
• In Adminstration > Role Management , enable user access to the "Find Duplicate Lots" page.
• Go to Stock > Find Duplicate Lots
  • Note the number of duplicates found (see the grid footer)
  • Click on the Action menu of any row and click on "Find duplicate lots". (I'm not 100% happy about the wording here; I'm open to suggestions).
  • A modal will pop up. Note that form will show all lots that have matching lot labels AND inventory UUIDs. Only one lot is shown for all the lots that match it.
  • Select the lot to keep and the lot(s) to merge
  • Click on the [Merge] button
  • When you return to the main grid, notice the offending row is now gone (since there is only one of them)

[jniles]

@jmcameron since you asked for a review of the functionality, I won't dive into the code yet.

Overall, looks really good for a first cut. Some suggestions:

1. Instead of "Find Lots" in the action menu, let's just call it "Merge Lots". To me, this is intuitive: instead of finding the lots, we've found them, now we are opening the modal to merge them.
2. Can you put a loading indicator on the loading button when merging lots? It seems like we should be waiting for that to be done on the server, then closing the modal, then reloading the page. It dismisses almost immediately, which surprised me. Most other modals that do something in the system (trial balance, credit note, etc) hang out until the action is performed with a loading indicator.

Here is what that looks like on a "good 2G network" that I emulated.

Again, haven't taken a look at the code, but it surprised me how quick that was!

[jmcameron]

@jniles This is now ready for a real review.

QUESTION: Should we remove the "Find Duplicate Lots" in the Lots registry action menu?

[jniles]

QUESTION: Should we remove the "Find Duplicate Lots" in the Lots registry action menu?

No, I do not think so. Let's wait until a couple of releases, then we'll remove it. I think that folks are much more inclined to absent-mindedly look at that registry (which they are using all the time) than they will be for this new module.

[jniles]

Functionally, this looks good to me. I've made a few clean up comments, but none of them are serious. Once addressed, this PR can be merged.

[jniles]

bors delegate+

[bors]

✌️ jmcameron can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[jmcameron]

bors r+

[bors]

Build succeeded:

• ci/semaphoreci/push: Integration Tests