Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bhStockFilterExhausted to support help text #5365

Conversation

jmcameron
Copy link
Collaborator

Fix bhStockFilterExhausted to enable callers to specify help text to be shown below the stock filter exhausted options. Note that this was not correctly implemented before (the help text was hardcoded).

Testing

  • Run Bhima
  • In the Stock Lots page, open the search modal and click on the defaults tab. There should be no additional text below the 'include exhausted lots' options.
  • Edit client/src/modules/stock/lots/modals/search.modal.html
  • Search for bh-stock-exhausted (around line 108)
  • Add this to the component invocation: help-text="TEST TEXT"
  • Run Bhima
  • In the Stock Lots page, open the search modal and click on the defaults tab. The additional text should appear below the 'include exhausted lots' options.

It is not clear that this will ever be needed, but since it was there, I though we should fix it so that it will work properly.

@jmcameron jmcameron requested a review from lomamech February 5, 2021 18:44
Copy link
Collaborator

@jniles jniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Good catch!

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 6, 2021

Build succeeded:

@bors bors bot merged commit 4394f28 into Third-Culture-Software:refactor-stock-management Feb 6, 2021
@jmcameron jmcameron deleted the stock_lots_delete_obsolete_code branch February 8, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants