Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): require depots for stock changes #6239

Merged

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jan 4, 2022

Makes the depot field a required field for viewing the stock changes report.

Closes #6154.

image

Makes the depot field a required field for viewing the stock changes
report.

Closes Third-Culture-Software#6154.
@jniles jniles added the Bug Fix label Jan 4, 2022
@jniles jniles requested a review from jmcameron January 4, 2022 20:21
Copy link
Collaborator

@jmcameron jmcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it does now produce a report, so the fix helps.

However, when I use the Vanga dataset, and tried the "Stock Changes Report" FY 2021, December 2021, either depot), i see that these columns are empty:

  • Quantity Consumed-
  • Quantity Lost
  • Quantity Remaining

So I'm not sure it is working correctly.

on-select-callback="ReportConfigCtrl.onSelectDepot(depot)">
<bh-clear on-clear="ReportConfigCtrl.clear('depot_uuid')"></bh-clear>
on-select-callback="ReportConfigCtrl.onSelectDepot(depot)"
required="true">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jniles
Copy link
Collaborator Author

jniles commented Jan 5, 2022

So .. we need a better name for this. It isn't actually a report. It's a document.

There will never be data in this report - it is meant to be printed out and recorded manually with pen/paper, then later used as a template for data entry for the "Aggregate Stock Consumption" module. So, what you are seeing is intended behavior.

I'm hoping we can sunset this completely soon because (1) it isn't working in production and (2) using ODK offline ( #6235) seems like a much better solution.

@jniles
Copy link
Collaborator Author

jniles commented Jan 5, 2022

Given that explanation, I'll merge this now (to fix the bug) and if we want to look into renaming, we should do that in a separate PR.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 5, 2022

Build succeeded:

@bors bors bot merged commit ab8997f into Third-Culture-Software:master Jan 5, 2022
@jniles jniles deleted the 6154-fix-stock-changes-report branch January 5, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stock Changes Report is broken
2 participants