Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing code in previous update #6254

Merged

Conversation

jmcameron
Copy link
Collaborator

Fix an error in PR #6243.
Somehow, code that was in the handlebars file got lost in the version that got released. This fix adds that code back in.

TESTING

  • Use production database
  • Try the report: Finance > Report > Open Debtors
    • Try it in the enterprise currency (default), and note a few numbers including the final total at the bottom of the report. Also, no exchange rate should be listed under the title.
    • Try it with some other currency and verify that the new numbers are correct. The exchange rate used should be listed at the top of the report (under the title).

@jmcameron jmcameron requested a review from jniles January 7, 2022 19:10
Copy link
Collaborator

@jniles jniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 8, 2022

Build succeeded:

@bors bors bot merged commit e4833f6 into Third-Culture-Software:master Jan 8, 2022
@jmcameron jmcameron deleted the fix-open-debtors-report branch January 10, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants