Trial Balance Implementation #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DedrickEnc, there will be issues with It might be work running |
DedrickEnc
force-pushed
the
trialB
branch
2 times, most recently
from
01d444a to
88ae774
Compare
|
@jniles |
| @@ -57,3 +57,20 @@ | |||
| /* this is full height minus the header crumb and util bar */ | |||
| height : calc(100vh - 65px - 35px); | |||
| } | |||
|
|
|||
| .error { | |||
There was a problem hiding this comment.
It is preferable to use the bootstrap classes and/or colors to keep uniform style. Are those classes insufficient?
If you must create your own classes, it is clearer to prefix these classes with the component they affect, like bootstrap (e.g bg-danger, btn-primary, etc). Could you put a prefix on these?
| ORDER BY p.trans_date DESC; | ||
| `; | ||
|
|
||
| return db.exec(sql, [ db.bid(record_uuid) ]) |
|
@jniles |
|
@Dedrick, good work. I'll merge this with the plan being to evolve the Trial Balance UI further into different |
4 tasks
bors bot
added a commit
that referenced
this pull request
Jul 19, 2019
3809: Update commitizen to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The devDependency [commitizen](https://github.com/commitizen/cz-cli) was updated from `3.1.2` to `4.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- **Publisher:** [commitizen-bot](https://www.npmjs.com/~commitizen-bot) **License:** MIT <details> <summary>Release Notes for v4.0.0</summary> <h1><a href="https://urls.greenkeeper.io/commitizen/cz-cli/compare/v3.1.2...v4.0.0">4.0.0</a> (2019-07-18)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>node:</strong> remove node 6 and 8 support (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/issues/649" data-hovercard-type="pull_request" data-hovercard-url="/commitizen/cz-cli/pull/649/hovercard">#649</a>) (<a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/8931c6b">8931c6b</a>)</li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li><strong>node:</strong> Removal of two major node versions, 6 and 8 from testing scheme</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 2 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/8931c6b9882ad83e07a21800c9caf42454d80952"><code>8931c6b</code></a> <code>fix(node): remove node 6 and 8 support (#649)</code></li> <li><a href="https://urls.greenkeeper.io/commitizen/cz-cli/commit/ad6f14c6f40f879e2775f12b19a155ed1143b5a2"><code>ad6f14c</code></a> <code>chore(deps): update dependency semantic-release to v15.13.18 (#644)</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/commitizen/cz-cli/compare/4417fcfc7f4715db48aa2e529cb112f32972d1cf...8931c6b9882ad83e07a21800c9caf42454d80952">full diff</a></p> </details> --- <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible of trial balance implementation and it will be updated as the work progress and at the end a full description of the PR will land to describe how it is implemented in terms of Technic and functionality.
As every check boxes are checked, the PR can have his first review as soon as possible (if the test passes of course)
The trial balance implemented is very closed to the bhima-1.X trial balance in terms of checking rules and UI interfaces chronology.
Notice that a basic UI interface was implemented for the general ledger just to let the browser redirect to this page so that the user can see the posted transactions.
Some routes has been added for :
/trial_balance/specific_route(3 in total)/journal/:trans_id(The possibility to fetch a specific transaction), just to make our integration test very rich but an other purpose for this route can be found in the future. Some test for some route has been added as well.The functionalities implemented has been tested (end to end test and integration test)
Some functionalities can be added in the current such as
@jniles @sfount