-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): ensure 2023 exists #6910
fix(tests): ensure 2023 exists #6910
Conversation
d9fe4f8
to
0c7a5e3
Compare
bors try |
tryBuild failed: |
bors try |
13ab373
to
28da93c
Compare
tryBuild failed: |
bors try |
tryBuild failed: |
f06f356
to
de1538c
Compare
bors try |
tryBuild succeeded: |
Let's try again. bors try |
tryBuild succeeded: |
Add 2024, not 2023 to FY test, increases the timeout for all test processing to allow browser to boot on limited hardware.
de1538c
to
33bb934
Compare
@mbayopanda this is ready for review. It appears that either semaphore got more limited hardware or the chrome browser became slower as the tests were timing out on PDF rendering and processing of several heavy MySQL queries. I am guessing the former. To fix, I increased the timeout on the tests (from 2 seconds to 20 seconds). I also added 2023 as a fiscal year (which we have to do every year) and made sure we dropped support for old NodeJS versions. Finally, I bumped the dependencies of several of the modules. |
@jniles good catch for the timeout extension, it seems like you didn't change anything related to timeout on the Semaphore-CI side. |
bors r+ |
Build succeeded: |
This commit adds the 2023 fiscal year to begin work on fixing the semaphore tests.