Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): ensure 2023 exists #6910

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Jan 17, 2023

This commit adds the 2023 fiscal year to begin work on fixing the semaphore tests.

@jniles jniles force-pushed the fix-fiscal-year-data-for-semaphore-tests branch 2 times, most recently from d9fe4f8 to 0c7a5e3 Compare January 17, 2023 16:18
@jniles
Copy link
Collaborator Author

jniles commented Jan 17, 2023

bors try

bors bot added a commit that referenced this pull request Jan 17, 2023
@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

try

Build failed:

@jniles
Copy link
Collaborator Author

jniles commented Jan 17, 2023

bors try

bors bot added a commit that referenced this pull request Jan 17, 2023
@jniles jniles force-pushed the fix-fiscal-year-data-for-semaphore-tests branch from 13ab373 to 28da93c Compare January 17, 2023 18:56
@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

try

Build failed:

@jniles
Copy link
Collaborator Author

jniles commented Jan 17, 2023

bors try

bors bot added a commit that referenced this pull request Jan 17, 2023
@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

try

Build failed:

@jniles jniles force-pushed the fix-fiscal-year-data-for-semaphore-tests branch from f06f356 to de1538c Compare January 17, 2023 20:57
@jniles
Copy link
Collaborator Author

jniles commented Jan 17, 2023

bors try

bors bot added a commit that referenced this pull request Jan 17, 2023
@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

try

Build succeeded:

@jniles
Copy link
Collaborator Author

jniles commented Jan 17, 2023

Let's try again.

bors try

bors bot added a commit that referenced this pull request Jan 17, 2023
@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

try

Build succeeded:

Add 2024, not 2023 to FY test, increases the timeout for all
test processing to allow browser to boot on limited hardware.
@jniles jniles force-pushed the fix-fiscal-year-data-for-semaphore-tests branch from de1538c to 33bb934 Compare January 17, 2023 21:12
@jniles
Copy link
Collaborator Author

jniles commented Jan 17, 2023

@mbayopanda this is ready for review.

It appears that either semaphore got more limited hardware or the chrome browser became slower as the tests were timing out on PDF rendering and processing of several heavy MySQL queries. I am guessing the former.

To fix, I increased the timeout on the tests (from 2 seconds to 20 seconds). I also added 2023 as a fiscal year (which we have to do every year) and made sure we dropped support for old NodeJS versions. Finally, I bumped the dependencies of several of the modules.

@mbayopanda
Copy link
Collaborator

@jniles good catch for the timeout extension, it seems like you didn't change anything related to timeout on the Semaphore-CI side.

@mbayopanda
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 19, 2023

Build succeeded:

@bors bors bot merged commit 1cf471f into Third-Culture-Software:master Jan 19, 2023
@jniles jniles deleted the fix-fiscal-year-data-for-semaphore-tests branch January 19, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants